Re: {PATCH] Re: wasting time on page fault

2000-10-11 Thread Mikael Pettersson
On Tue, 10 Oct 2000, Jamie Lokier wrote: >> > 1. Move the error_code block from divide_error to page_fault; >> >this removes one jump from the page_fault path. >> >> It is not clear that it is worth it. You want to align error_code and >> page_fault to 16 or 32 bytes bytes at least, and it w

Re: {PATCH] Re: wasting time on page fault

2000-10-10 Thread Jamie Lokier
Linus Torvalds wrote: > > The assembler doesn't use nops for alignment -- it inserts longer > > instructions that are effectively nops, either 1 or two. For larger > > stretches, the assembler inserts a jmp itself for alignment. > > Note that some of them are not very good no-ops. At least at so

Re: {PATCH] Re: wasting time on page fault

2000-10-10 Thread Linus Torvalds
On Tue, 10 Oct 2000, Jamie Lokier wrote: > > The assembler doesn't use nops for alignment -- it inserts longer > instructions that are effectively nops, either 1 or two. For larger > stretches, the assembler inserts a jmp itself for alignment. Note that some of them are not very good no-ops.

Re: {PATCH] Re: wasting time on page fault

2000-10-10 Thread Jamie Lokier
Andi Kleen wrote: > > 1. Move the error_code block from divide_error to page_fault; > >this removes one jump from the page_fault path. > > It is not clear that it is worth it. You want to align error_code and > page_fault to 16 or 32 bytes bytes at least, and it would need to execute > some n

Re: {PATCH] Re: wasting time on page fault

2000-10-09 Thread Andi Kleen
On Mon, Oct 09, 2000 at 08:37:55PM +0200, Mikael Pettersson wrote: > We could also do the following: > > 1. Move the error_code block from divide_error to page_fault; >this removes one jump from the page_fault path. It is not clear that it is worth it. You want to align error_code and page_f

Re: {PATCH] Re: wasting time on page fault

2000-10-09 Thread Mikael Pettersson
On Wed, 04 Oct 2000, Brian Gerst wrote: >Mikulas Patocka wrote: >> >> Hi. >> >> arch/i386/kernel/entry.S >> xchgl %eax, ORIG_EAX(%esp) # orig_eax (get the error code. ) >> movl %esp,%edx >> xchgl %ecx, ES(%esp)# get the address and save es. >> pu

{PATCH] Re: wasting time on page fault

2000-10-04 Thread Brian Gerst
Mikulas Patocka wrote: > > Hi. > > arch/i386/kernel/entry.S > xchgl %eax, ORIG_EAX(%esp) # orig_eax (get the error code. ) > movl %esp,%edx > xchgl %ecx, ES(%esp)# get the address and save es. > pushl %eax # push the error cod