Re: [xfs-masters] Re: 2.6.22-rc1-mm1

2007-05-22 Thread Nathan Scott
On Tue, 2007-05-22 at 20:44 +1000, David Chinner wrote: > > > xfs_buf_associate_memory is a mess. My original plan was to get rid > of > > it, but I kept that out to keep that patchset small and easily > reviable, > > but it seems like that was a mistake. My plan is the following: > > > > - xl

Re: [xfs-masters] Re: 2.6.22-rc1-mm1

2007-05-22 Thread Michal Piotrowski
Hi David, On 21/05/07, David Chinner <[EMAIL PROTECTED]> wrote: On Fri, May 18, 2007 at 12:11:14PM +1000, David Chinner wrote: > On Thu, May 17, 2007 at 10:05:11PM +0200, Michal Piotrowski wrote: > > I applied your patch and I get another oops > > > > [ 261.491499] XFS mounting filesystem loop0

Re: [xfs-masters] Re: 2.6.22-rc1-mm1

2007-05-22 Thread Christoph Hellwig
On Tue, May 22, 2007 at 08:44:30PM +1000, David Chinner wrote: > Perhaps a new field in the xfs_buf structure - that way call paths > don't need to grow extra parameters and potentially increase > stack usage. The read path tends to be at the top of the stack > when it gets blown in the writeback p

Re: [xfs-masters] Re: 2.6.22-rc1-mm1

2007-05-22 Thread David Chinner
On Mon, May 21, 2007 at 12:23:21PM +0200, Christoph Hellwig wrote: > On Mon, May 21, 2007 at 08:11:42PM +1000, David Chinner wrote: > > Christoph - this is an interaction with xfs_buf_associate_memory(); > > I'm not sure what it is doing is at all safe now that it never gets > > passed kmem_alloc()

Re: [xfs-masters] Re: 2.6.22-rc1-mm1

2007-05-21 Thread Christoph Hellwig
On Mon, May 21, 2007 at 08:11:42PM +1000, David Chinner wrote: > Christoph - this is an interaction with xfs_buf_associate_memory(); > I'm not sure what it is doing is at all safe now that it never gets > passed kmem_alloc()d memory - it works for the log recovery case > because we use it in pairs

Re: [xfs-masters] Re: 2.6.22-rc1-mm1

2007-05-21 Thread David Chinner
On Fri, May 18, 2007 at 12:11:14PM +1000, David Chinner wrote: > On Thu, May 17, 2007 at 10:05:11PM +0200, Michal Piotrowski wrote: > > I applied your patch and I get another oops > > > > [ 261.491499] XFS mounting filesystem loop0 > > [ 261.501641] Ending clean XFS mount for filesystem: loop0 >

Re: [xfs-masters] Re: 2.6.22-rc1-mm1

2007-05-17 Thread David Chinner
On Thu, May 17, 2007 at 10:05:11PM +0200, Michal Piotrowski wrote: > I applied your patch and I get another oops > > [ 261.491499] XFS mounting filesystem loop0 > [ 261.501641] Ending clean XFS mount for filesystem: loop0 > [ 261.507698] SELinux: initialized (dev loop0, type xfs), uses xattr >

Re: [xfs-masters] Re: 2.6.22-rc1-mm1

2007-05-17 Thread Michal Piotrowski
Hi Christoph, Christoph Hellwig napisaƂ(a): > On Thu, May 17, 2007 at 12:06:00PM +1000, David Chinner wrote: >>> static inline int put_page_testzero(struct page *page) >>> { >>> VM_BUG_ON(atomic_read(&page->_count) == 0); >>> return atomic_dec_and_test(&page->_count); >>> } >> I haven't se

Re: [xfs-masters] Re: 2.6.22-rc1-mm1

2007-05-17 Thread Christoph Hellwig
On Thu, May 17, 2007 at 12:06:00PM +1000, David Chinner wrote: > > static inline int put_page_testzero(struct page *page) > > { > > VM_BUG_ON(atomic_read(&page->_count) == 0); > > return atomic_dec_and_test(&page->_count); > > } > > I haven't seen that one. I expect that it will be the noa