Re: [v5 PATCH 04/11] mm: vmscan: remove memcg_shrinker_map_size

2021-01-29 Thread Yang Shi
On Fri, Jan 29, 2021 at 3:22 AM Vlastimil Babka wrote: > > On 1/28/21 10:22 PM, Yang Shi wrote: > >> > @@ -266,12 +265,13 @@ int alloc_shrinker_maps(struct mem_cgroup *memcg) > >> > static int expand_shrinker_maps(int new_id) > >> > { > >> > int size, old_size, ret = 0; > >> > + int ne

Re: [v5 PATCH 04/11] mm: vmscan: remove memcg_shrinker_map_size

2021-01-28 Thread Yang Shi
On Thu, Jan 28, 2021 at 8:53 AM Vlastimil Babka wrote: > > On 1/28/21 12:33 AM, Yang Shi wrote: > > Both memcg_shrinker_map_size and shrinker_nr_max is maintained, but > > actually the > > map size can be calculated via shrinker_nr_max, so it seems unnecessary to > > keep both. > > Remove memcg_

Re: [v5 PATCH 04/11] mm: vmscan: remove memcg_shrinker_map_size

2021-01-28 Thread Vlastimil Babka
On 1/28/21 12:33 AM, Yang Shi wrote: > Both memcg_shrinker_map_size and shrinker_nr_max is maintained, but actually > the > map size can be calculated via shrinker_nr_max, so it seems unnecessary to > keep both. > Remove memcg_shrinker_map_size since shrinker_nr_max is also used by > iterating t

[v5 PATCH 04/11] mm: vmscan: remove memcg_shrinker_map_size

2021-01-27 Thread Yang Shi
Both memcg_shrinker_map_size and shrinker_nr_max is maintained, but actually the map size can be calculated via shrinker_nr_max, so it seems unnecessary to keep both. Remove memcg_shrinker_map_size since shrinker_nr_max is also used by iterating the bit map. Signed-off-by: Yang Shi --- mm/vmsc