[v5 1/2] dt-bindings: gpio: aspeed: Add SGPIO support

2019-07-30 Thread Hongwei Zhang
ux-aspeed; Bartosz Golaszewski; Rob > Herring; Mark Rutland; > linux-kernel@vger.kernel.org; Linux ARM > Subject: Re: [v5 1/2] dt-bindings: gpio: aspeed: Add SGPIO support > > On Mon, Jul 29, 2019 at 2:19 AM Andrew Jeffery wrote: > > > The behaviour is to period

Re: [v5 1/2] dt-bindings: gpio: aspeed: Add SGPIO support

2019-07-29 Thread Linus Walleij
On Mon, Jul 29, 2019 at 2:19 AM Andrew Jeffery wrote: > The behaviour is to periodically emit the state of all enabled GPIOs > (i.e. the ngpios value), one per bus clock cycle. There's no explicit > addressing scheme, the protocol encodes the value for a given GPIO > by its position in the data s

Re: [v5 1/2] dt-bindings: gpio: aspeed: Add SGPIO support

2019-07-28 Thread Andrew Jeffery
On Mon, 29 Jul 2019, at 09:04, Linus Walleij wrote: > On Mon, Jul 22, 2019 at 3:42 AM Andrew Jeffery wrote: > > > If the clock driver owns the control register, it also needs to know how > > many GPIOs we want to emit on the bus. This seems like an awkward > > configuration parameter for a clo

Re: [v5 1/2] dt-bindings: gpio: aspeed: Add SGPIO support

2019-07-28 Thread Linus Walleij
On Mon, Jul 22, 2019 at 3:42 AM Andrew Jeffery wrote: > If the clock driver owns the control register, it also needs to know how > many GPIOs we want to emit on the bus. This seems like an awkward > configuration parameter for a clock driver. > > To avoid the weird parameter we could protect the

Re: [v5 1/2] dt-bindings: gpio: aspeed: Add SGPIO support

2019-07-21 Thread Andrew Jeffery
On Sat, 20 Jul 2019, at 17:43, Linus Walleij wrote: > Hi Hongwei, > > after looking close at the driver and bindings I have this feeback: > > On Fri, Jul 19, 2019 at 9:25 PM Hongwei Zhang wrote: > > +- reg : Address and length of the register set for the > device > > This

Re: [v5 1/2] dt-bindings: gpio: aspeed: Add SGPIO support

2019-07-20 Thread Linus Walleij
Hi Hongwei, after looking close at the driver and bindings I have this feeback: On Fri, Jul 19, 2019 at 9:25 PM Hongwei Zhang wrote: +- reg : Address and length of the register set for the device This 0x100 range may look simple but in the driver it looks like this: +static c

[v5 1/2] dt-bindings: gpio: aspeed: Add SGPIO support

2019-07-19 Thread Hongwei Zhang
Add bindings to support SGPIO on AST2400 or AST2500. Signed-off-by: Hongwei Zhang --- .../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 ++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt diff --git a/Documen