Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-11 Thread Atish Patra
> On Feb 11, 2019, at 2:23 PM, Palmer Dabbelt wrote: > > On Mon, 11 Feb 2019 14:13:25 PST (-0800), marc.zyng...@arm.com wrote: >> On Mon, 11 Feb 2019 12:03:30 -0800 >> Atish Patra wrote: >> >>> On 2/11/19 11:02 AM, Palmer Dabbelt wrote: >>> > On Fri, 08 Feb 2019 20:26:07 PST (-0800), david.a

Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-11 Thread Palmer Dabbelt
On Mon, 11 Feb 2019 14:13:25 PST (-0800), marc.zyng...@arm.com wrote: On Mon, 11 Feb 2019 12:03:30 -0800 Atish Patra wrote: On 2/11/19 11:02 AM, Palmer Dabbelt wrote: > On Fri, 08 Feb 2019 20:26:07 PST (-0800), david.abdurachma...@gmail.com wrote: >> On Sat, Feb 9, 2019 at 12:03 AM Atish Patra

Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-11 Thread Marc Zyngier
On Mon, 11 Feb 2019 12:03:30 -0800 Atish Patra wrote: > On 2/11/19 11:02 AM, Palmer Dabbelt wrote: > > On Fri, 08 Feb 2019 20:26:07 PST (-0800), david.abdurachma...@gmail.com > > wrote: > >> On Sat, Feb 9, 2019 at 12:03 AM Atish Patra wrote: > >>> > >>> On 2/8/19 1:11 AM, Christoph Hellwig

Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-11 Thread Atish Patra
On 2/11/19 11:02 AM, Palmer Dabbelt wrote: On Fri, 08 Feb 2019 20:26:07 PST (-0800), david.abdurachma...@gmail.com wrote: On Sat, Feb 9, 2019 at 12:03 AM Atish Patra wrote: On 2/8/19 1:11 AM, Christoph Hellwig wrote: + * We don't support running Linux on hertergenous ISA systems. + *

Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-11 Thread Palmer Dabbelt
On Fri, 08 Feb 2019 20:26:07 PST (-0800), david.abdurachma...@gmail.com wrote: On Sat, Feb 9, 2019 at 12:03 AM Atish Patra wrote: On 2/8/19 1:11 AM, Christoph Hellwig wrote: >> + * We don't support running Linux on hertergenous ISA systems. >> + * But first "okay" processor might not b

Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-11 Thread Andreas Schwab
On Feb 07 2019, Atish Patra wrote: > + while ((node = of_find_node_by_type(node, "cpu"))) { > + if (!node) { That can never be true. > + pr_warn("Unable to find \"cpu\" devicetree entry"); > + return; > + } > + > +

Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-09 Thread Marc Zyngier
On Sat, 09 Feb 2019 04:26:07 +, David Abdurachmanov wrote: > > On Sat, Feb 9, 2019 at 12:03 AM Atish Patra wrote: > > > > On 2/8/19 1:11 AM, Christoph Hellwig wrote: > > >> + * We don't support running Linux on hertergenous ISA systems. > > >> + * But first "okay" processor might not

Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-08 Thread David Abdurachmanov
On Sat, Feb 9, 2019 at 12:03 AM Atish Patra wrote: > > On 2/8/19 1:11 AM, Christoph Hellwig wrote: > >> + * We don't support running Linux on hertergenous ISA systems. > >> + * But first "okay" processor might not be the boot cpu. > >> + * Check the ISA of boot cpu. > > > > Please use

Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-08 Thread Atish Patra
On 2/8/19 1:11 AM, Christoph Hellwig wrote: +* We don't support running Linux on hertergenous ISA systems. +* But first "okay" processor might not be the boot cpu. +* Check the ISA of boot cpu. Please use up your available 80 characters per line in comments. I will fix

Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-08 Thread Christoph Hellwig
> + * We don't support running Linux on hertergenous ISA systems. > + * But first "okay" processor might not be the boot cpu. > + * Check the ISA of boot cpu. Please use up your available 80 characters per line in comments. > + /* > + * All "okay" hart shou

[v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.

2019-02-07 Thread Atish Patra
Currently, we set hwcap based on first valid cpu from DT. This may not be correct always as that CPU might not be current booting cpu. Set hwcap based on the boot cpu instead of first valid CPU from DT. Add a sanity check to identify if any hwcap do not match. Signed-off-by: Atish Patra --- arc