Re: [v3 PATCH 04/10] x86/insn-kernel: Add a function to obtain register offset in ModRM

2017-01-31 Thread Ricardo Neri
On Fri, 2017-01-27 at 16:53 +0900, Masami Hiramatsu wrote: > On Wed, 25 Jan 2017 22:07:16 -0800 > Ricardo Neri wrote: > > > Hi Masami, > > > > On Thu, 2017-01-26 at 11:11 +0900, Masami Hiramatsu wrote: > > > On Wed, 25 Jan 2017 12:23:47 -0800 > > > Ricardo Neri wrote: > > > > > > > The functio

Re: [v3 PATCH 04/10] x86/insn-kernel: Add a function to obtain register offset in ModRM

2017-01-26 Thread Masami Hiramatsu
On Wed, 25 Jan 2017 22:07:16 -0800 Ricardo Neri wrote: > Hi Masami, > > On Thu, 2017-01-26 at 11:11 +0900, Masami Hiramatsu wrote: > > On Wed, 25 Jan 2017 12:23:47 -0800 > > Ricardo Neri wrote: > > > > > The function insn_get_reg_offset requires a type to indicate whether > > > the returned of

Re: [v3 PATCH 04/10] x86/insn-kernel: Add a function to obtain register offset in ModRM

2017-01-25 Thread Ricardo Neri
Hi Masami, On Thu, 2017-01-26 at 11:11 +0900, Masami Hiramatsu wrote: > On Wed, 25 Jan 2017 12:23:47 -0800 > Ricardo Neri wrote: > > > The function insn_get_reg_offset requires a type to indicate whether > > the returned offset is that given by by the ModRM or the SIB byte. > > Callers of this f

Re: [v3 PATCH 04/10] x86/insn-kernel: Add a function to obtain register offset in ModRM

2017-01-25 Thread Masami Hiramatsu
On Wed, 25 Jan 2017 12:23:47 -0800 Ricardo Neri wrote: > The function insn_get_reg_offset requires a type to indicate whether > the returned offset is that given by by the ModRM or the SIB byte. > Callers of this function would need the definition of the type struct. > This is not needed. Instead

[v3 PATCH 04/10] x86/insn-kernel: Add a function to obtain register offset in ModRM

2017-01-25 Thread Ricardo Neri
The function insn_get_reg_offset requires a type to indicate whether the returned offset is that given by by the ModRM or the SIB byte. Callers of this function would need the definition of the type struct. This is not needed. Instead, auxiliary functions can be defined for this purpose. When the