Re: [v3 PATCH] usb: create usb_debug_root for gadget only

2019-06-03 Thread Chunfeng Yun
On Fri, 2019-05-31 at 08:44 +0300, Felipe Balbi wrote: > Hi, > > Chunfeng Yun writes: > > > Hi Felipe, > > On Tue, 2019-05-28 at 11:11 +0300, Felipe Balbi wrote: > >> Hi, > >> > >> Chunfeng Yun writes: > >> > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > >> > index 7fcb9f78293

Re: [v3 PATCH] usb: create usb_debug_root for gadget only

2019-05-30 Thread Felipe Balbi
Hi, Chunfeng Yun writes: > Hi Felipe, > On Tue, 2019-05-28 at 11:11 +0300, Felipe Balbi wrote: >> Hi, >> >> Chunfeng Yun writes: >> > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c >> > index 7fcb9f782931..88b3ee03a12d 100644 >> > --- a/drivers/usb/core/usb.c >> > +++ b/drivers

Re: [v3 PATCH] usb: create usb_debug_root for gadget only

2019-05-30 Thread Chunfeng Yun
Hi Felipe, On Tue, 2019-05-28 at 11:11 +0300, Felipe Balbi wrote: > Hi, > > Chunfeng Yun writes: > > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > > index 7fcb9f782931..88b3ee03a12d 100644 > > --- a/drivers/usb/core/usb.c > > +++ b/drivers/usb/core/usb.c > > @@ -1190,7 +1190,7 @@

Re: [v3 PATCH] usb: create usb_debug_root for gadget only

2019-05-28 Thread Chunfeng Yun
Hi Felipe, On Tue, 2019-05-28 at 11:11 +0300, Felipe Balbi wrote: > Hi, > > Chunfeng Yun writes: > > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > > index 7fcb9f782931..88b3ee03a12d 100644 > > --- a/drivers/usb/core/usb.c > > +++ b/drivers/usb/core/usb.c > > @@ -1190,7 +1190,7 @@

Re: [v3 PATCH] usb: create usb_debug_root for gadget only

2019-05-28 Thread Chunfeng Yun
add Felipe, sorry On Tue, 2019-05-28 at 15:54 +0800, Chunfeng Yun wrote: > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set, > there is an issue, e.g.: > > drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root': > mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb

Re: [v3 PATCH] usb: create usb_debug_root for gadget only

2019-05-28 Thread Felipe Balbi
Hi, Chunfeng Yun writes: > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > index 7fcb9f782931..88b3ee03a12d 100644 > --- a/drivers/usb/core/usb.c > +++ b/drivers/usb/core/usb.c > @@ -1190,7 +1190,7 @@ EXPORT_SYMBOL_GPL(usb_debug_root); > > static void usb_debugfs_init(void) >

[v3 PATCH] usb: create usb_debug_root for gadget only

2019-05-28 Thread Chunfeng Yun
When CONFIG_USB is not set, and CONFIG_USB_GADGET is set, there is an issue, e.g.: drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root': mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root' usb_debug_root is currently only built when host is supported (CONFIG_