Re: [v2 PATCH] rhashtable: Still do rehash when we get EEXIST

2019-01-26 Thread Josh Elsasser
On Jan 23, 2019, at 7:40 PM, Josh Elsasser wrote: > On Jan 23, 2019, at 7:08 PM, Herbert Xu wrote: > >> Thanks for catching this! >> >> Although I think we should fix this in a different way. The problem >> here is that the shrink cannot proceed because there was a previous >> rehash that is s

Re: [v2 PATCH] rhashtable: Still do rehash when we get EEXIST

2019-01-23 Thread Josh Elsasser
On Jan 23, 2019, at 7:08 PM, Herbert Xu wrote: > Thanks for catching this! > > Although I think we should fix this in a different way. The problem > here is that the shrink cannot proceed because there was a previous > rehash that is still incomplete. We should wait for its completion > and th

[v2 PATCH] rhashtable: Still do rehash when we get EEXIST

2019-01-23 Thread Herbert Xu
On Wed, Jan 23, 2019 at 01:17:58PM -0800, Josh Elsasser wrote: > When running workloads with large bursts of fragmented packets, we've seen > a few machines stuck returning -EEXIST from rht_shrink() and endlessly > rescheduling their hash table's deferred work, pegging a CPU core. > > Root cause i