Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers

2020-10-08 Thread Eric Biggers
On Thu, Oct 08, 2020 at 08:36:23AM +0200, Corentin Labbe wrote: > On Thu, Oct 08, 2020 at 04:52:38PM +1100, Herbert Xu wrote: > > On Thu, Sep 24, 2020 at 03:27:38PM +0200, Corentin Labbe wrote: > > > > > > This is an example on next-20200923+BigEndian > > > alg: ahash: sha1 test failed (wrong resul

Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers

2020-10-07 Thread Corentin Labbe
On Thu, Oct 08, 2020 at 04:52:38PM +1100, Herbert Xu wrote: > On Thu, Sep 24, 2020 at 03:27:38PM +0200, Corentin Labbe wrote: > > > > This is an example on next-20200923+BigEndian > > alg: ahash: sha1 test failed (wrong result) on test vector \"random: > > psize=194 ksize=0\", cfg=\"random: inplac

Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers

2020-10-07 Thread Herbert Xu
On Thu, Sep 24, 2020 at 03:27:38PM +0200, Corentin Labbe wrote: > > This is an example on next-20200923+BigEndian > alg: ahash: sha1 test failed (wrong result) on test vector \"random: > psize=194 ksize=0\", cfg=\"random: inplace may_sleep use_finup > src_divs=[98.25%@+1124, 1.75%@+5] iv_offset=1

Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers

2020-09-24 Thread Corentin Labbe
On Thu, Sep 24, 2020 at 01:08:59PM +1000, Herbert Xu wrote: > On Mon, Sep 14, 2020 at 12:40:58PM +0200, Corentin Labbe wrote: > > > > I got this on next-20200910/multi_v7_defconfig BigEndian > > [ 12.137856] alg: hash: skipping comparison tests for md5-sun4i-ss > > because md5-generic is unavail

Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers

2020-09-23 Thread Herbert Xu
On Mon, Sep 14, 2020 at 12:40:58PM +0200, Corentin Labbe wrote: > > I got this on next-20200910/multi_v7_defconfig BigEndian > [ 12.137856] alg: hash: skipping comparison tests for md5-sun4i-ss because > md5-generic is unavailable > md5-sun4i-ss md5 reqs=763 > [ 98.286632] alg: ahash: md5 test

Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers

2020-09-14 Thread Corentin Labbe
On Fri, Sep 11, 2020 at 02:13:55PM +1000, Herbert Xu wrote: > On Thu, Sep 10, 2020 at 02:22:48PM +0200, Corentin Labbe wrote: > > > > I get some md5 error on both A20+BE: > > alg: ahash: md5 test failed (wrong result) on test vector \"random: > > psize=129 ksize=0\", cfg=\"random: inplace use_finu

Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers

2020-09-14 Thread Corentin Labbe
On Fri, Sep 11, 2020 at 02:13:55PM +1000, Herbert Xu wrote: > On Thu, Sep 10, 2020 at 02:22:48PM +0200, Corentin Labbe wrote: > > > > I get some md5 error on both A20+BE: > > alg: ahash: md5 test failed (wrong result) on test vector \"random: > > psize=129 ksize=0\", cfg=\"random: inplace use_finu

Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers

2020-09-10 Thread Herbert Xu
On Thu, Sep 10, 2020 at 02:22:48PM +0200, Corentin Labbe wrote: > > I get some md5 error on both A20+BE: > alg: ahash: md5 test failed (wrong result) on test vector \"random: psize=129 > ksize=0\", cfg=\"random: inplace use_finup nosimd > src_divs=[85.99%@+3999, 5.85%@+30, 0.96%@+25, > 5.9%@+226

Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers

2020-09-10 Thread Corentin Labbe
On Tue, Sep 08, 2020 at 03:00:36PM +1000, Herbert Xu wrote: > On Mon, Sep 07, 2020 at 06:00:29PM +0200, Corentin Labbe wrote: > > > > The put_unaligned should be _le32. > > > > This fix the modprobe tcrypt fail. > > Thanks. Yes the original code was correct. > > ---8<--- > This patch also fixes

[v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers

2020-09-07 Thread Herbert Xu
On Mon, Sep 07, 2020 at 06:00:29PM +0200, Corentin Labbe wrote: > > The put_unaligned should be _le32. > > This fix the modprobe tcrypt fail. Thanks. Yes the original code was correct. ---8<--- This patch also fixes the incorrect endianness markings in the sun4i-ss driver. It should have no ef