Re: [v2] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-20 Thread Cyrill Gorcunov
On Fri, Apr 20, 2018 at 04:29:03PM +0900, Sergey Senozhatsky wrote: > > > > I don't mind. Could you please make the patch on top of linux-next? > > As far as I can see, it's not in linux-next yet. So the following is > against the mmots tree. I wouldn't mind it if we could just squash the > patch

Re: [v2] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-20 Thread Sergey Senozhatsky
On (04/20/18 10:02), Cyrill Gorcunov wrote: > On Fri, Apr 20, 2018 at 11:38:09AM +0900, Sergey Senozhatsky wrote: > > On (04/05/18 21:26), Cyrill Gorcunov wrote: > > [..] > > > - > > > #ifdef CONFIG_CHECKPOINT_RESTORE > > > if (opt == PR_SET_MM_MAP || opt == PR_SET_MM_MAP_SIZE) > > > r

Re: [v2] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-20 Thread Cyrill Gorcunov
On Fri, Apr 20, 2018 at 11:38:09AM +0900, Sergey Senozhatsky wrote: > On (04/05/18 21:26), Cyrill Gorcunov wrote: > [..] > > - > > #ifdef CONFIG_CHECKPOINT_RESTORE > > if (opt == PR_SET_MM_MAP || opt == PR_SET_MM_MAP_SIZE) > > return prctl_set_mm_map(opt, (const void __user *)addr,

Re: [v2] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-19 Thread Sergey Senozhatsky
On (04/05/18 21:26), Cyrill Gorcunov wrote: [..] > - > #ifdef CONFIG_CHECKPOINT_RESTORE > if (opt == PR_SET_MM_MAP || opt == PR_SET_MM_MAP_SIZE) > return prctl_set_mm_map(opt, (const void __user *)addr, arg4); > #endif > > - if (!capable(CAP_SYS_RESOURCE)) > -

Re: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-18 Thread Cyrill Gorcunov
On Wed, Apr 18, 2018 at 03:28:20PM -0700, Andrew Morton wrote: > On Thu, 5 Apr 2018 21:26:51 +0300 Cyrill Gorcunov wrote: > > > Subject: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations > > s/Deprecate/remove/ ! Thanks! > > > > Googling didn

Re: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-18 Thread Andrew Morton
On Thu, 5 Apr 2018 21:26:51 +0300 Cyrill Gorcunov wrote: > Subject: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations s/Deprecate/remove/ ! > An ability to manipulate mm_struct fields was introduced in > sake of CRIU in first place. Later we provide more suitable > and sa

Re: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-05 Thread Cyrill Gorcunov
On Thu, Apr 05, 2018 at 08:56:50PM +0200, Michal Hocko wrote: > On Thu 05-04-18 21:26:51, Cyrill Gorcunov wrote: > > An ability to manipulate mm_struct fields was introduced in > > sake of CRIU in first place. Later we provide more suitable > > and safe operation PR_SET_MM_MAP where all fields to b

Re: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-05 Thread Yang Shi
On 4/5/18 11:26 AM, Cyrill Gorcunov wrote: An ability to manipulate mm_struct fields was introduced in sake of CRIU in first place. Later we provide more suitable and safe operation PR_SET_MM_MAP where all fields to be modifed are passed in one structure which allows us to make more detailed ve

Re: [PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-05 Thread Michal Hocko
On Thu 05-04-18 21:26:51, Cyrill Gorcunov wrote: > An ability to manipulate mm_struct fields was introduced in > sake of CRIU in first place. Later we provide more suitable > and safe operation PR_SET_MM_MAP where all fields to be modifed > are passed in one structure which allows us to make more d

[PATCH v2] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-05 Thread Cyrill Gorcunov
An ability to manipulate mm_struct fields was introduced in sake of CRIU in first place. Later we provide more suitable and safe operation PR_SET_MM_MAP where all fields to be modifed are passed in one structure which allows us to make more detailed verification. Still old interface remains presen