Re: [v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h

2025-02-06 Thread Shyam Saini
Hi Everyone, On Wed, Feb 05, 2025 at 09:43:12AM +0100, Rasmus Villemoes wrote: > On Mon, Feb 03 2025, Shyam Saini wrote: > > > Move the following to module.h to allow common usages: > > - lookup_or_create_module_kobject() > > - to_module_attr > > - to_module_kobject > > > > This makes lookup_

Re: [v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h

2025-02-05 Thread Rasmus Villemoes
On Mon, Feb 03 2025, Shyam Saini wrote: > Move the following to module.h to allow common usages: > - lookup_or_create_module_kobject() > - to_module_attr > - to_module_kobject > > This makes lookup_or_create_module_kobject() as inline. > > Signed-off-by: Shyam Saini > --- > include/linux/mod

Re: [v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h

2025-02-04 Thread Christophe Leroy
Le 04/02/2025 à 06:22, Shyam Saini a écrit : [Vous ne recevez pas souvent de courriers de shyamsa...@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] Move the following to module.h to allow common usages: - lookup_or_create_modul

Re: [v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h

2025-02-03 Thread Christoph Hellwig
> +static inline struct module_kobject * __init > lookup_or_create_module_kobject(const char *name) Crazily unreadable line. Either way this is not a function that should be inline in a header. Both due to sheer size, but also due to what it does and what it pulls in. > +{ > + struct module

[v1 2/3] include: move lookup_or_create_module_kobject()/to_module* to module.h

2025-02-03 Thread Shyam Saini
Move the following to module.h to allow common usages: - lookup_or_create_module_kobject() - to_module_attr - to_module_kobject This makes lookup_or_create_module_kobject() as inline. Signed-off-by: Shyam Saini --- include/linux/module.h | 39 +++ kernel/p