Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-26 Thread Borislav Petkov
On Mon, Feb 26, 2018 at 11:02:56AM +0300, Kirill A. Shutemov wrote: > Yeah, good idea. > > Borislav, could you check this? No joy with: diff --git a/arch/x86/boot/compressed/pgtable_64.c b/arch/x86/boot/compressed/pgtable_64.c index dad5da7b4c1a..4c382409b740 100644 --- a/arch/x86/boot/compress

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-26 Thread Cyrill Gorcunov
On Mon, Feb 26, 2018 at 11:37:09AM +0300, Kirill A. Shutemov wrote: > On Mon, Feb 26, 2018 at 11:15:34AM +0300, Cyrill Gorcunov wrote: > > On Mon, Feb 26, 2018 at 11:02:56AM +0300, Kirill A. Shutemov wrote: > > ... > > > > Also, could do a puts() hexdump of the affected memory area _before_ we > >

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-26 Thread Ingo Molnar
* Kirill A. Shutemov wrote: > > Also, could do a puts() hexdump of the affected memory area _before_ we > > overwrite > > it? Is it empty? Could we add some debug warning that checks that it's all > > zeroes? > > The problem is that we don't really have a way get a message out of there. Is

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-26 Thread Kirill A. Shutemov
On Mon, Feb 26, 2018 at 11:15:34AM +0300, Cyrill Gorcunov wrote: > On Mon, Feb 26, 2018 at 11:02:56AM +0300, Kirill A. Shutemov wrote: > ... > > > Also, could do a puts() hexdump of the affected memory area _before_ we > > > overwrite > > > it? Is it empty? Could we add some debug warning that ch

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-26 Thread Cyrill Gorcunov
On Mon, Feb 26, 2018 at 11:02:56AM +0300, Kirill A. Shutemov wrote: ... > > Also, could do a puts() hexdump of the affected memory area _before_ we > > overwrite > > it? Is it empty? Could we add some debug warning that checks that it's all > > zeroes? > > The problem is that we don't really ha

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-26 Thread Kirill A. Shutemov
On Mon, Feb 26, 2018 at 08:50:27AM +0100, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > We need to re-do this as we have now run into _exactly_ the kind of > > difficult to > > debug bug that I was worried about when I insisted on the many iterations > > of > > this patch-set... > > Ok,

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-26 Thread Kirill A. Shutemov
On Mon, Feb 26, 2018 at 08:35:52AM +0100, Ingo Molnar wrote: > > * Kirill A. Shutemov wrote: > > > +#if 0 > > /* > > * Find a suitable spot for the trampoline. > > * This code is based on reserve_bios_regions(). > > @@ -49,6 +50,9 @@ struct paging_config paging_prepare(void) > >

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-25 Thread Ingo Molnar
* Ingo Molnar wrote: > We need to re-do this as we have now run into _exactly_ the kind of difficult > to > debug bug that I was worried about when I insisted on the many iterations of > this patch-set... Ok, so I rebased tip:x86/mm and removed these two commits: adf9ca9c69a2: x86/boot/comp

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-25 Thread Ingo Molnar
* Kirill A. Shutemov wrote: > +#if 0 > /* >* Find a suitable spot for the trampoline. >* This code is based on reserve_bios_regions(). > @@ -49,6 +50,9 @@ struct paging_config paging_prepare(void) > /* Place the trampoline just below the end of low memory, aligned to

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-25 Thread Kirill A. Shutemov
On Sun, Feb 25, 2018 at 01:29:24PM +0100, Borislav Petkov wrote: > On Sun, Feb 25, 2018 at 01:52:05PM +0300, Kirill A. Shutemov wrote: > > Could you check if the patch below makes a difference? > > > > If it is, could you check 0x9d000 address instead of 0x99000? > > Both don't make a difference.

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-25 Thread Borislav Petkov
On Sun, Feb 25, 2018 at 01:52:05PM +0300, Kirill A. Shutemov wrote: > Could you check if the patch below makes a difference? > > If it is, could you check 0x9d000 address instead of 0x99000? Both don't make a difference. Thx. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-25 Thread Kirill A. Shutemov
On Sat, Feb 24, 2018 at 10:48:18PM +0100, Borislav Petkov wrote: > On Sun, Feb 11, 2018 at 04:19:38AM -0800, tip-bot for Kirill A. Shutemov > wrote: > > Commit-ID: b91993a87aff6dafd60a9c8ce80ebc425161a815 > > Gitweb: > > https://git.kernel.org/tip/b91993a87aff6dafd60a9c8ce80ebc425161a815 > >

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-24 Thread Borislav Petkov
On Sun, Feb 11, 2018 at 04:19:38AM -0800, tip-bot for Kirill A. Shutemov wrote: > Commit-ID: b91993a87aff6dafd60a9c8ce80ebc425161a815 > Gitweb: > https://git.kernel.org/tip/b91993a87aff6dafd60a9c8ce80ebc425161a815 > Author: Kirill A. Shutemov > AuthorDate: Fri, 9 Feb 2018 17:22:27 +0300

Re: [tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-13 Thread Cyrill Gorcunov
On Sun, Feb 11, 2018 at 04:19:38AM -0800, tip-bot for Kirill A. Shutemov wrote: ... > diff --git a/arch/x86/boot/compressed/head_64.S > b/arch/x86/boot/compressed/head_64.S > index d598d65..af9ffbd 100644 > --- a/arch/x86/boot/compressed/head_64.S > +++ b/arch/x86/boot/compressed/head_64.S ... > @

[tip:x86/boot] x86/boot/compressed/64: Prepare trampoline memory

2018-02-11 Thread tip-bot for Kirill A. Shutemov
Commit-ID: b91993a87aff6dafd60a9c8ce80ebc425161a815 Gitweb: https://git.kernel.org/tip/b91993a87aff6dafd60a9c8ce80ebc425161a815 Author: Kirill A. Shutemov AuthorDate: Fri, 9 Feb 2018 17:22:27 +0300 Committer: Ingo Molnar CommitDate: Sun, 11 Feb 2018 12:36:19 +0100 x86/boot/compressed/6