Re: [sched] 23f0d2093c: -12.6% regression on sparse file copy

2014-01-05 Thread Joonsoo Kim
On Mon, Jan 06, 2014 at 03:10:07PM +0800, Fengguang Wu wrote: > Hi Joonsoo, > > On Mon, Jan 06, 2014 at 09:30:52AM +0900, Joonsoo Kim wrote: > > On Sun, Jan 05, 2014 at 05:04:56PM +0800, fengguang...@intel.com wrote: > > > Hi Joonsoo, > > > > > > We noticed the below changes for commit 23f0d2093c

Re: [sched] 23f0d2093c: -12.6% regression on sparse file copy

2014-01-05 Thread Fengguang Wu
Hi Joonsoo, On Mon, Jan 06, 2014 at 09:30:52AM +0900, Joonsoo Kim wrote: > On Sun, Jan 05, 2014 at 05:04:56PM +0800, fengguang...@intel.com wrote: > > Hi Joonsoo, > > > > We noticed the below changes for commit 23f0d2093c ("sched: Factor out > > code to should_we_balance()") in test vm-scalabilit

Re: [sched] 23f0d2093c: -12.6% regression on sparse file copy

2014-01-05 Thread Joonsoo Kim
On Sun, Jan 05, 2014 at 05:04:56PM +0800, fengguang...@intel.com wrote: > Hi Joonsoo, > > We noticed the below changes for commit 23f0d2093c ("sched: Factor out > code to should_we_balance()") in test vm-scalability/300s-lru-file-readtwice Hello, Fengguang. There was a mistake in this patch and

[sched] 23f0d2093c: -12.6% regression on sparse file copy

2014-01-05 Thread fengguang . wu
Hi Joonsoo, We noticed the below changes for commit 23f0d2093c ("sched: Factor out code to should_we_balance()") in test vm-scalability/300s-lru-file-readtwice 95a79b805b935f4 23f0d2093c789e612185180c4 --- - ==> 4.45 ~ 5% +1777.7%