Re: [rtc-linux] [PATCH] rtc: recycle id when unloading a rtc driver

2012-12-27 Thread Alexander Holler
Am 19.12.2012 09:55, schrieb Alexander Holler: Unlikely, as I've worked hard to get one of the first drivers for pluggable RTCs into the kernel. ;) BTW. maybe you could have a look at the patch for that: https://lkml.org/lkml/2012/12/15/64 It should already be in your mailbox. I had to move

Re: [rtc-linux] [PATCH] rtc: recycle id when unloading a rtc driver

2012-12-19 Thread Alexander Holler
Am 19.12.2012 23:37, schrieb Andrew Morton: > I think I'll do this: > > > From: Andrew Morton > Subject: revert "rtc: recycle id when unloading a rtc driver" Thanks a lot, I just haven't seen the stuff got broken with 3.7 as I haven't played much with RTCs before (just used them). So I didn't

Re: [rtc-linux] [PATCH] rtc: recycle id when unloading a rtc driver

2012-12-19 Thread Andrew Morton
On Wed, 19 Dec 2012 09:55:02 +0100 Alexander Holler wrote: > Am 19.12.2012 09:27, schrieb Andrew Morton: > > On Wed, 19 Dec 2012 08:55:57 +0100 Alexander Holler > > wrote: > > > >>> > >>> I'm all confused. > >>> > >>> Lothar's patch simply reverts Vincent's patch. And that appears to be > >>>

Re: [rtc-linux] [PATCH] rtc: recycle id when unloading a rtc driver

2012-12-19 Thread Alexander Holler
Am 19.12.2012 09:27, schrieb Andrew Morton: On Wed, 19 Dec 2012 08:55:57 +0100 Alexander Holler wrote: I'm all confused. Lothar's patch simply reverts Vincent's patch. And that appears to be the correct thing to so, as the ida_simple_remove() in rtc_device_release() should be sufficient.

Re: [rtc-linux] [PATCH] rtc: recycle id when unloading a rtc driver

2012-12-19 Thread Andrew Morton
On Wed, 19 Dec 2012 08:55:57 +0100 Alexander Holler wrote: > > > > I'm all confused. > > > > Lothar's patch simply reverts Vincent's patch. And that appears to be > > the correct thing to so, as the ida_simple_remove() in > > rtc_device_release() should be sufficient. > > > > But apparently tha

Re: [rtc-linux] [PATCH] rtc: recycle id when unloading a rtc driver

2012-12-18 Thread Alexander Holler
Am 19.12.2012 08:45, schrieb Andrew Morton: On Wed, 19 Dec 2012 08:37:07 +0100 Alexander Holler wrote: Am 19.12.2012 01:46, schrieb Andrew Morton: On Thu, 2 Aug 2012 16:53:25 -0700 Vincent Palatin wrote: When calling rtc_device_unregister, we are not freeing the id used by the driver. So

Re: [rtc-linux] [PATCH] rtc: recycle id when unloading a rtc driver

2012-12-18 Thread Andrew Morton
On Wed, 19 Dec 2012 08:37:07 +0100 Alexander Holler wrote: > Am 19.12.2012 01:46, schrieb Andrew Morton: > > On Thu, 2 Aug 2012 16:53:25 -0700 > > Vincent Palatin wrote: > > > >> When calling rtc_device_unregister, we are not freeing the id used by the > >> driver. > >> So when doing a unload/

Re: [rtc-linux] [PATCH] rtc: recycle id when unloading a rtc driver

2012-12-18 Thread Alexander Holler
Am 19.12.2012 01:46, schrieb Andrew Morton: On Thu, 2 Aug 2012 16:53:25 -0700 Vincent Palatin wrote: When calling rtc_device_unregister, we are not freeing the id used by the driver. So when doing a unload/load cycle for a RTC driver (e.g. rmmod rtc_cmos && modprobe rtc_cmos), its id is incre

Re: [rtc-linux] [PATCH] rtc: recycle id when unloading a rtc driver

2012-12-18 Thread Andrew Morton
On Thu, 2 Aug 2012 16:53:25 -0700 Vincent Palatin wrote: > When calling rtc_device_unregister, we are not freeing the id used by the > driver. > So when doing a unload/load cycle for a RTC driver (e.g. rmmod rtc_cmos > && modprobe rtc_cmos), its id is incremented by one. As a consequence, > we n