Re: [rfc PATCH] ieee1394: ohci1394: delete bogus spinlock, flush MMIO writes

2006-11-28 Thread Alan
On Wed, 29 Nov 2006 00:50:43 +0100 Stefan Richter <[EMAIL PROTECTED]> wrote: > Alan wrote: > > On Tue, 28 Nov 2006 22:24:11 +0100 (CET) > > Stefan Richter <[EMAIL PROTECTED]> wrote: > >> All MMIO writes which were surrounded by the spinlock as well as the > >> very last MMIO write of the IRQ handl

Re: [rfc PATCH] ieee1394: ohci1394: delete bogus spinlock, flush MMIO writes

2006-11-28 Thread Stefan Richter
Alan wrote: > On Tue, 28 Nov 2006 22:24:11 +0100 (CET) > Stefan Richter <[EMAIL PROTECTED]> wrote: >> All MMIO writes which were surrounded by the spinlock as well as the >> very last MMIO write of the IRQ handler are now explicitly flushed by >> MMIO reads of the respective register. > > MMIO is

Re: [rfc PATCH] ieee1394: ohci1394: delete bogus spinlock, flush MMIO writes

2006-11-28 Thread Alan
On Tue, 28 Nov 2006 22:24:11 +0100 (CET) Stefan Richter <[EMAIL PROTECTED]> wrote: > All MMIO writes which were surrounded by the spinlock as well as the > very last MMIO write of the IRQ handler are now explicitly flushed by > MMIO reads of the respective register. MMIO is ordered anyway on the

[rfc PATCH] ieee1394: ohci1394: delete bogus spinlock, flush MMIO writes

2006-11-28 Thread Stefan Richter
Remove a per-host spinlock which was only taken by the IRQ handler, i.e. where no concurrency was involved. All MMIO writes which were surrounded by the spinlock as well as the very last MMIO write of the IRQ handler are now explicitly flushed by MMIO reads of the respective register. Signed-off-