Re: [perf] perf_event.h ABI visibility question

2018-08-29 Thread Peter Zijlstra
On Tue, Aug 28, 2018 at 01:51:29PM -0400, Vince Weaver wrote: > On Mon, 27 Aug 2018, Peter Zijlstra wrote: > > > Something like so then? > > > > diff --git a/include/uapi/linux/perf_event.h > > b/include/uapi/linux/perf_event.h > > index eeb787b1c53c..f35eb72739c0 100644 > > --- a/include/uapi/l

Re: [perf] perf_event.h ABI visibility question

2018-08-28 Thread Vince Weaver
On Mon, 27 Aug 2018, Peter Zijlstra wrote: > Something like so then? > > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index eeb787b1c53c..f35eb72739c0 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -144,7 +144,7 @@ e

Re: [perf] perf_event.h ABI visibility question

2018-08-27 Thread Peter Zijlstra
On Fri, Aug 24, 2018 at 05:09:27PM -0400, Vince Weaver wrote: > On Fri, 24 Aug 2018, Peter Zijlstra wrote: > > > > +++ b/include/uapi/linux/perf_event.h > > > @@ -143,6 +143,8 @@ enum perf_event_sample_format { > > > PERF_SAMPLE_PHYS_ADDR = 1U << 19, > > > > > >

Re: [perf] perf_event.h ABI visibility question

2018-08-24 Thread Vince Weaver
On Fri, 24 Aug 2018, Peter Zijlstra wrote: > > +++ b/include/uapi/linux/perf_event.h > > @@ -143,6 +143,8 @@ enum perf_event_sample_format { > > PERF_SAMPLE_PHYS_ADDR = 1U << 19, > > > > PERF_SAMPLE_MAX = 1U << 20, /* non-ABI */ > > + > > + __P

Re: [perf] perf_event.h ABI visibility question

2018-08-24 Thread Peter Zijlstra
On Thu, Aug 23, 2018 at 02:25:06PM -0400, Vince Weaver wrote: > > I notice that Linux 4.18 has the following changeset which changes the > user visible perf_event.h file > > commit 6cbc304f2f360f25cc8607817239d6f4a2fd3dc5 > Author: Peter Zijlstra > Date: Thu May 10 15:48:41 2

[perf] perf_event.h ABI visibility question

2018-08-23 Thread Vince Weaver
I notice that Linux 4.18 has the following changeset which changes the user visible perf_event.h file commit 6cbc304f2f360f25cc8607817239d6f4a2fd3dc5 Author: Peter Zijlstra Date: Thu May 10 15:48:41 2018 +0200 perf/x86/intel: Fix unwind errors from PEBS entries (m