Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-19 Thread Alex Shi
On 06/19/2013 04:15 PM, Alex Shi wrote: > On 06/18/2013 05:44 PM, Alex Shi wrote: >> >>> >>> Paul, could I summary your point here: >>> keep current weighted_cpu_load, but add blocked load avg in >>> get_rq_runnable_load? >>> >>> I will test this change. >> >> Current testing(kbuild, oltp, aim7) do

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-19 Thread Alex Shi
On 06/18/2013 05:44 PM, Alex Shi wrote: > >> >> Paul, could I summary your point here: >> keep current weighted_cpu_load, but add blocked load avg in >> get_rq_runnable_load? >> >> I will test this change. > > Current testing(kbuild, oltp, aim7) don't show clear different on my NHM EP > box > be

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-18 Thread Alex Shi
> > Paul, could I summary your point here: > keep current weighted_cpu_load, but add blocked load avg in > get_rq_runnable_load? > > I will test this change. Current testing(kbuild, oltp, aim7) don't show clear different on my NHM EP box between the following and the origin patch, the only dif

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-17 Thread Alex Shi
On 06/18/2013 07:00 AM, Paul Turner wrote: > On Mon, Jun 17, 2013 at 6:57 AM, Alex Shi wrote: >> > On 06/17/2013 08:17 PM, Paul Turner wrote: >>> >> On Mon, Jun 17, 2013 at 3:51 AM, Paul Turner wrote: >>> On Fri, Jun 7, 2013 at 12:20 AM, Alex Shi wrote: > They are the base values i

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-17 Thread Paul Turner
On Mon, Jun 17, 2013 at 6:57 AM, Alex Shi wrote: > On 06/17/2013 08:17 PM, Paul Turner wrote: >> On Mon, Jun 17, 2013 at 3:51 AM, Paul Turner wrote: >>> On Fri, Jun 7, 2013 at 12:20 AM, Alex Shi wrote: They are the base values in load balance, update them with rq runnable load average,

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-17 Thread Alex Shi
On 06/17/2013 10:57 PM, Alex Shi wrote: >> > >> > Did you try including blocked_load_avg in only get_rq_runnable_load() >> > [ and not weighted_cpuload() which is called by new-idle ]? >> > > No, but blocked_load_avg also impact periodic balance much. The ideal > scenario is a sleeping task will

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-17 Thread Alex Shi
On 06/17/2013 06:51 PM, Paul Turner wrote: > This looks fine. > > Did you try including blocked_load_avg in only get_rq_runnable_load() > [ and not weighted_cpuload() which is called by new-idle ]? > No, but blocked_load_avg also impact periodic balance much. The ideal scenario is a sleeping tas

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-17 Thread Alex Shi
On 06/17/2013 09:39 PM, Peter Zijlstra wrote: >>> > > >>> > > This looks fine. >>> > > >>> > > Did you try including blocked_load_avg in only get_rq_runnable_load() >>> > > [ and not weighted_cpuload() which is called by new-idle ]? >> > >> > Looking at this more this feels less correct since you'

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-17 Thread Alex Shi
On 06/17/2013 08:17 PM, Paul Turner wrote: > On Mon, Jun 17, 2013 at 3:51 AM, Paul Turner wrote: >> On Fri, Jun 7, 2013 at 12:20 AM, Alex Shi wrote: >>> They are the base values in load balance, update them with rq runnable >>> load average, then the load balance will consider runnable load avg >

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-17 Thread Peter Zijlstra
On Mon, Jun 17, 2013 at 05:17:17AM -0700, Paul Turner wrote: > On Mon, Jun 17, 2013 at 3:51 AM, Paul Turner wrote: > > On Fri, Jun 7, 2013 at 12:20 AM, Alex Shi wrote: > >> They are the base values in load balance, update them with rq runnable > >> load average, then the load balance will conside

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-17 Thread Paul Turner
On Mon, Jun 17, 2013 at 3:51 AM, Paul Turner wrote: > On Fri, Jun 7, 2013 at 12:20 AM, Alex Shi wrote: >> They are the base values in load balance, update them with rq runnable >> load average, then the load balance will consider runnable load avg >> naturally. >> >> We also try to include the bl

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-17 Thread Paul Turner
On Fri, Jun 7, 2013 at 12:20 AM, Alex Shi wrote: > They are the base values in load balance, update them with rq runnable > load average, then the load balance will consider runnable load avg > naturally. > > We also try to include the blocked_load_avg as cpu load in balancing, > but that cause kb

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-09 Thread Gu Zheng
On 06/10/2013 10:01 AM, Alex Shi wrote: > On 06/10/2013 09:49 AM, Gu Zheng wrote: >> On 06/07/2013 03:20 PM, Alex Shi wrote: >> They are the base values in load balance, update them with rq runnable load average, then the load balance will consider runnable load avg naturally.

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-09 Thread Alex Shi
On 06/10/2013 09:49 AM, Gu Zheng wrote: > On 06/07/2013 03:20 PM, Alex Shi wrote: > >> > They are the base values in load balance, update them with rq runnable >> > load average, then the load balance will consider runnable load avg >> > naturally. >> > >> > We also try to include the blocked_loa

Re: [patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-09 Thread Gu Zheng
On 06/07/2013 03:20 PM, Alex Shi wrote: > They are the base values in load balance, update them with rq runnable > load average, then the load balance will consider runnable load avg > naturally. > > We also try to include the blocked_load_avg as cpu load in balancing, > but that cause kbuild per

[patch v8 6/9] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2013-06-07 Thread Alex Shi
They are the base values in load balance, update them with rq runnable load average, then the load balance will consider runnable load avg naturally. We also try to include the blocked_load_avg as cpu load in balancing, but that cause kbuild performance drop 6% on every Intel machine, and aim7/olt