Re: [patch v3] x86, UV: integer wrap bug in uv_hub_ipi_value()

On Sun, Dec 02, 2012 at 08:28:43PM +0300, Dan Carpenter wrote: > This is a static checker fix. The problem is that we store the bits > from "uv_apicid_hibits" into "apicid" (the high 16 bits) but then we > shift it 16 bit to the left. "apicid" is an int so it wraps and we lose > them. > > I have

[patch v3] x86, UV: integer wrap bug in uv_hub_ipi_value()

This is a static checker fix. The problem is that we store the bits from "uv_apicid_hibits" into "apicid" (the high 16 bits) but then we shift it 16 bit to the left. "apicid" is an int so it wraps and we lose them. I have also simplified uv_wakeup_secondary() a little based on a suggestion. Sig