Re: [patch v2] hugetlb: correct page offset index for sharing pmd

2012-08-16 Thread Hillf Danton
On Thu, Aug 16, 2012 at 7:03 AM, Andrew Morton wrote: > Don't be too concerned about the size of a change - it's the end result > which matters. If a larger patch results in a better end result, then > do the larger patch. Hi Andrew, This work was triggered by the fact that huge_pmd_share mism

Re: [patch v2] hugetlb: correct page offset index for sharing pmd

2012-08-15 Thread Andrew Morton
On Mon, 6 Aug 2012 21:37:45 +0800 Hillf Danton wrote: > On Mon, Aug 6, 2012 at 9:24 PM, Michal Hocko wrote: > > On Sat 04-08-12 14:08:31, Hillf Danton wrote: > >> The computation of page offset index is incorrect to be used in scanning > >> prio tree, as huge page offset is required, and is fixe

Re: [patch v2] hugetlb: correct page offset index for sharing pmd

2012-08-07 Thread Hillf Danton
On Mon, Aug 6, 2012 at 11:54 PM, Michal Hocko wrote: > It's just that page_table_shareable fix the index silently by saddr & > PUD_MASK. Follow no up, and see no wrong in page_table_shareable frankly. Hillf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [patch v2] hugetlb: correct page offset index for sharing pmd

2012-08-06 Thread Michal Hocko
On Mon 06-08-12 21:37:45, Hillf Danton wrote: > On Mon, Aug 6, 2012 at 9:24 PM, Michal Hocko wrote: > > On Sat 04-08-12 14:08:31, Hillf Danton wrote: > >> The computation of page offset index is incorrect to be used in scanning > >> prio tree, as huge page offset is required, and is fixed with wel

Re: [patch v2] hugetlb: correct page offset index for sharing pmd

2012-08-06 Thread Hillf Danton
On Mon, Aug 6, 2012 at 9:24 PM, Michal Hocko wrote: > On Sat 04-08-12 14:08:31, Hillf Danton wrote: >> The computation of page offset index is incorrect to be used in scanning >> prio tree, as huge page offset is required, and is fixed with well >> defined routine. >> >> Changes from v1 >> o

Re: [patch v2] hugetlb: correct page offset index for sharing pmd

2012-08-06 Thread Michal Hocko
On Sat 04-08-12 14:08:31, Hillf Danton wrote: > The computation of page offset index is incorrect to be used in scanning > prio tree, as huge page offset is required, and is fixed with well > defined routine. > > Changes from v1 > o s/linear_page_index/linear_hugepage_index/ for clearer code

[patch v2] hugetlb: correct page offset index for sharing pmd

2012-08-03 Thread Hillf Danton
The computation of page offset index is incorrect to be used in scanning prio tree, as huge page offset is required, and is fixed with well defined routine. Changes from v1 o s/linear_page_index/linear_hugepage_index/ for clearer code o hp_idx variable added for less change Signe