In addition to what Paolo's noticed, may be change printk to pr_info()
while editing around it:
> -
> printk(KERN_INFO "kvm-clock: Using msrs %x and %x",
> msr_kvm_system_time, msr_kvm_wall_clock);
>
> + hv_clock = (struct pvclock_vsyscall_time_info *)hv_clock_mem;
>
On Fri, 6 Jul 2018, Paolo Bonzini wrote:
> Decrapification went a bit too far...
>
> On 06/07/2018 18:13, Thomas Gleixner wrote:
> > - int cpu = smp_processor_id();
> > - int low, high, ret;
> > struct pvclock_vcpu_time_info *src;
> > + int cpu = smp_processor_id();
> > + u64 pa;
> >
Decrapification went a bit too far...
On 06/07/2018 18:13, Thomas Gleixner wrote:
> - int cpu = smp_processor_id();
> - int low, high, ret;
> struct pvclock_vcpu_time_info *src;
> + int cpu = smp_processor_id();
> + u64 pa;
>
> if (!hv_clock)
> - return 0;
The return value is pointless because the wrmsr cannot fail if
KVM_FEATURE_CLOCKSOURCE or KVM_FEATURE_CLOCKSOURCE2 are set.
kvm_register_clock() is only called locally so wants to be static.
Signed-off-by: Thomas Gleixner
Cc: Paolo Bonzini
Cc: Radim Krcmar
Cc: Peter Zijlstra
Cc: Juergen Gross
4 matches
Mail list logo
