Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-16 Thread Pavel Machek
Hi! > > > It's peculiar that the hang happens when acpi_evaluate_object() hits its > > > return statement. Any theories there? > > > > Only stack or memory corruption come into mind, but I have no clue how > > this is related to the resume logic changes. > > So I had the brilliant idea of turni

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-13 Thread Thomas Gleixner
On Sun, 2007-05-13 at 23:42 -0700, Andrew Morton wrote: > On Sun, 13 May 2007 18:12:50 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > On Sat, 2007-05-12 at 02:00 -0700, Andrew Morton wrote: > > > Still hangs in the same fashion, sorry. > > > > > > It's peculiar that the hang happens when

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-13 Thread Andrew Morton
On Sun, 13 May 2007 18:12:50 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Sat, 2007-05-12 at 02:00 -0700, Andrew Morton wrote: > > Still hangs in the same fashion, sorry. > > > > It's peculiar that the hang happens when acpi_evaluate_object() hits its > > return statement. Any theories

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-13 Thread Andrew Morton
On Sun, 13 May 2007 22:07:39 +0200 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > Yeah, I expect quite a few people will start seeing that. iirc it was > > triggered by a couple of changes: a local_irq_save/local_irq_restore > > in sched_clock() an

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-13 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > Yeah, I expect quite a few people will start seeing that. iirc it was > triggered by a couple of changes: a local_irq_save/local_irq_restore > in sched_clock() and a change Jeremy made to the softlockup detector. hm, i specifically asked to not do

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-13 Thread Andrew Morton
On Sun, 13 May 2007 18:48:07 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Sun, 2007-05-13 at 10:07 +0200, Thomas Gleixner wrote: > > > > Can you send me your .config please ? > > > > > > > > > > http://userweb.kernel.org/~akpm/config-sony.txt > > > > No luck. > > I'm making progress.

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-13 Thread Thomas Gleixner
On Sun, 2007-05-13 at 10:07 +0200, Thomas Gleixner wrote: > > > Can you send me your .config please ? > > > > > > > http://userweb.kernel.org/~akpm/config-sony.txt > > No luck. I'm making progress. After fiddling with the config options I get a solid lockup of netconsole during boot :( But al

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-13 Thread Thomas Gleixner
On Sat, 2007-05-12 at 02:00 -0700, Andrew Morton wrote: > Still hangs in the same fashion, sorry. > > It's peculiar that the hang happens when acpi_evaluate_object() hits its > return statement. Any theories there? I assume you have a printk right before the return and one after the call to acpi

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-13 Thread Thomas Gleixner
On Sat, 2007-05-12 at 18:11 -0700, Andrew Morton wrote: > On Sat, 12 May 2007 21:56:10 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > On Sat, 2007-05-12 at 10:23 -0700, Andrew Morton wrote: > > > The broken-out queue should turn up at > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Andrew Morton
On Sat, 12 May 2007 21:56:10 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Sat, 2007-05-12 at 10:23 -0700, Andrew Morton wrote: > > The broken-out queue should turn up at > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/ > > in a few minutes. > > Sigh. I can't reproduce your lockd

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Sat, 2007-05-12 at 10:23 -0700, Andrew Morton wrote: > The broken-out queue should turn up at > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/ > in a few minutes. Sigh. I can't reproduce your lockdep problem :( Can you send me your .config please ? tglx - To unsubscribe from

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Sat, 2007-05-12 at 10:23 -0700, Andrew Morton wrote: > On Sat, 12 May 2007 19:01:41 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > Can you upload a snapshot of your current queue ? > > Yeah, that's super-easy. It just happens that it all compiles > and runs at present ;) Really ? /h

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Sat, 2007-05-12 at 19:01 +0200, Thomas Gleixner wrote: > On Sat, 2007-05-12 at 09:51 -0700, Andrew Morton wrote: > > The locking in clocksource_resume_watchdog looks pretty pointless anyway. > > Can't we just delete it? > > > > The only thing it can race against is, conceivably, > > > >

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Andrew Morton
On Sat, 12 May 2007 19:01:41 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > Can you upload a snapshot of your current queue ? Yeah, that's super-easy. It just happens that it all compiles and runs at present ;) The single-big-patch is at http://userweb.kernel.org/~akpm/tg.bz2 The broken-ou

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Sat, 2007-05-12 at 09:51 -0700, Andrew Morton wrote: > The locking in clocksource_resume_watchdog looks pretty pointless anyway. > Can't we just delete it? > > The only thing it can race against is, conceivably, > > resumed = watchdog_resumed; > if (unlikely(resumed)) >

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Andrew Morton
On Sat, 12 May 2007 13:44:13 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > lockdep complains about the lock nesting of clocksource and watchdog > lock in the resume path. Move watchdog resume out of the clocksource > lock. > > Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]> > > Index: li

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Sat, 2007-05-12 at 03:07 -0700, Andrew Morton wrote: > On Sat, 12 May 2007 11:18:09 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > > It's peculiar that the hang happens when acpi_evaluate_object() hits its > > > return statement. Any theories there? > > > > Only stack or memory corrup

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Sat, 2007-05-12 at 03:07 -0700, Andrew Morton wrote: > On Sat, 12 May 2007 11:18:09 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > > It's peculiar that the hang happens when acpi_evaluate_object() hits its > > > return statement. Any theories there? > > > > Only stack or memory corrup

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Andrew Morton
On Sat, 12 May 2007 11:18:09 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > It's peculiar that the hang happens when acpi_evaluate_object() hits its > > return statement. Any theories there? > > Only stack or memory corruption come into mind, but I have no clue how > this is related to the

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Sat, 2007-05-12 at 02:00 -0700, Andrew Morton wrote: > > Still hangs in the same fashion, sorry. I did not really expect that it fixes the problem. It just restored the local APIC suspend/resume register fiddling which we had before the resume logic patch. > It's peculiar that the hang happens

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Andrew Morton
On Sat, 12 May 2007 10:46:03 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Fri, 2007-05-11 at 23:56 -0700, Andrew Morton wrote: > > On Fri, 11 May 2007 23:09:15 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > > wrote: > > > > > > > > > > > > hm, Fedora don't seem to want to give me an R

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-12 Thread Thomas Gleixner
On Fri, 2007-05-11 at 23:56 -0700, Andrew Morton wrote: > On Fri, 11 May 2007 23:09:15 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > wrote: > > > > > > > > > hm, Fedora don't seem to want to give me an RPM which contains acpidump > > > > and > > > > all the yum servers are featuring scrogged

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-11 Thread Andrew Morton
On Fri, 11 May 2007 23:09:15 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > > hm, Fedora don't seem to want to give me an RPM which contains acpidump > > > and > > > all the yum servers are featuring scrogged checksums. I could build it, I > > > guess, but there's a principle i

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-11 Thread Rafael J. Wysocki
On Friday, 11 May 2007 23:02, Rafael J. Wysocki wrote: > On Friday, 11 May 2007 22:28, Andrew Morton wrote: > > On Fri, 11 May 2007 22:10:24 +0200 > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > > > Index: linux-2.6.21/drivers/acpi/hardware/hwsleep.c > > > > >

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-11 Thread Rafael J. Wysocki
On Friday, 11 May 2007 22:28, Andrew Morton wrote: > On Fri, 11 May 2007 22:10:24 +0200 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > Index: linux-2.6.21/drivers/acpi/hardware/hwsleep.c > > > > === > > > > --- linux-2.6.2

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-11 Thread Andrew Morton
On Fri, 11 May 2007 22:10:24 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > Index: linux-2.6.21/drivers/acpi/hardware/hwsleep.c > > > === > > > --- linux-2.6.21.orig/drivers/acpi/hardware/hwsleep.c > > > +++ linux-2.6.21/d

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-11 Thread Rafael J. Wysocki
On Friday, 11 May 2007 18:47, Andrew Morton wrote: > On Thu, 10 May 2007 22:12:07 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > wrote: > > > On Thursday, 10 May 2007 11:27, Thomas Gleixner wrote: > > > On Thu, 2007-05-10 at 02:18 -0700, Andrew Morton wrote: > > > > > > > If that patch makes the

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-11 Thread Andrew Morton
On Thu, 10 May 2007 22:12:07 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Thursday, 10 May 2007 11:27, Thomas Gleixner wrote: > > On Thu, 2007-05-10 at 02:18 -0700, Andrew Morton wrote: > > > > > > If that patch makes the problem go away, then we should have a quite > > > > > > good

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-10 Thread Rafael J. Wysocki
On Thursday, 10 May 2007 11:27, Thomas Gleixner wrote: > On Thu, 2007-05-10 at 02:18 -0700, Andrew Morton wrote: > > > > > If that patch makes the problem go away, then we should have a quite > > > > > good hint what we need to look at. > > > > > > > > No joy, sorry. It still hangs at the last st

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-10 Thread Thomas Gleixner
On Thu, 2007-05-10 at 02:18 -0700, Andrew Morton wrote: > > > > If that patch makes the problem go away, then we should have a quite > > > > good hint what we need to look at. > > > > > > No joy, sorry. It still hangs at the last statement in > > > acpi_evaluate_object(). > > > > Can you add "n

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-10 Thread Andrew Morton
On Thu, 10 May 2007 10:55:45 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Thu, 2007-05-10 at 01:46 -0700, Andrew Morton wrote: > > On Wed, 09 May 2007 23:26:22 +0200 Thomas Gleixner <[EMAIL PROTECTED]> > > wrote: > > > > > Andrew, > > > > > > can you test the alternative replacement pa

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-10 Thread Thomas Gleixner
On Thu, 2007-05-10 at 01:46 -0700, Andrew Morton wrote: > On Wed, 09 May 2007 23:26:22 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > Andrew, > > > > can you test the alternative replacement patch for > > > > clockevents: Fix resume logic - updated version > > > > It does not touch the

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-10 Thread Andrew Morton
On Wed, 09 May 2007 23:26:22 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > Andrew, > > can you test the alternative replacement patch for > > clockevents: Fix resume logic - updated version > > It does not touch the interrupt controller, it does the PIT restart > different. That's a patch

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Thomas Gleixner
On Wed, 2007-05-09 at 22:53 +0200, Rafael J. Wysocki wrote: > On Wednesday, 9 May 2007 22:45, Thomas Gleixner wrote: > > On Wed, 2007-05-09 at 20:36 +0200, Rafael J. Wysocki wrote: > > > Well, apparently, not in -mm2: > > > > > > [EMAIL PROTECTED]:~/src/mm/linux-2.6.21-mm2> grep -r -I -l > > > 't

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 22:45, Thomas Gleixner wrote: > On Wed, 2007-05-09 at 20:36 +0200, Rafael J. Wysocki wrote: > > Well, apparently, not in -mm2: > > > > [EMAIL PROTECTED]:~/src/mm/linux-2.6.21-mm2> grep -r -I -l > > 'timekeeping_resume' * > > kernel/time/timekeeping.c > > [EMAIL PROTECTED]

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Thomas Gleixner
On Wed, 2007-05-09 at 20:36 +0200, Rafael J. Wysocki wrote: > Well, apparently, not in -mm2: > > [EMAIL PROTECTED]:~/src/mm/linux-2.6.21-mm2> grep -r -I -l > 'timekeeping_resume' * > kernel/time/timekeeping.c > [EMAIL PROTECTED]:~/src/mm/linux-2.6.21-mm2> grep clocksource_resume > kernel/time/ti

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 19:14, Andrew Morton wrote: > On Wed, 9 May 2007 14:52:07 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > wrote: > > > > Andrew, could you please apply the appended patch and see if that > > > helps (should apply to -mm2)? > > > > Argh, sorry. This needs yet another pat

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 19:15, Thomas Gleixner wrote: > On Wed, 2007-05-09 at 19:09 +0200, Rafael J. Wysocki wrote: > > > > Well, where is unregister_time_interpolator() called from? > > > > > > # grep -rn unregister_time_interpolator . > > > ./kernel/timer.c:1893:unregister_time_interpolator(str

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Andrew Morton
On Wed, 9 May 2007 14:52:07 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > Andrew, could you please apply the appended patch and see if that > > helps (should apply to -mm2)? > > Argh, sorry. This needs yet another patch (sent for review to linux-pm) to > be applied. The following one

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Thomas Gleixner
On Wed, 2007-05-09 at 19:09 +0200, Rafael J. Wysocki wrote: > > > Well, where is unregister_time_interpolator() called from? > > > > # grep -rn unregister_time_interpolator . > > ./kernel/timer.c:1893:unregister_time_interpolator(struct time_interpolator > > *ti) > > ./include/linux/timex.h:270:e

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 15:19, Thomas Gleixner wrote: > On Wed, 2007-05-09 at 15:12 +0200, Rafael J. Wysocki wrote: > > On Wednesday, 9 May 2007 14:24, Thomas Gleixner wrote: > > > On Wed, 2007-05-09 at 13:45 +0200, Rafael J. Wysocki wrote: > > > > On Wednesday, 9 May 2007 10:59, Thomas Gleixner w

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Thomas Gleixner
On Wed, 2007-05-09 at 15:12 +0200, Rafael J. Wysocki wrote: > On Wednesday, 9 May 2007 14:24, Thomas Gleixner wrote: > > On Wed, 2007-05-09 at 13:45 +0200, Rafael J. Wysocki wrote: > > > On Wednesday, 9 May 2007 10:59, Thomas Gleixner wrote: > > > > On Wed, 2007-05-09 at 01:31 -0700, Andrew Morton

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 14:24, Thomas Gleixner wrote: > On Wed, 2007-05-09 at 13:45 +0200, Rafael J. Wysocki wrote: > > On Wednesday, 9 May 2007 10:59, Thomas Gleixner wrote: > > > On Wed, 2007-05-09 at 01:31 -0700, Andrew Morton wrote: > > > > > I suspect I just tested the wrong thing yesterday.

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 13:45, Rafael J. Wysocki wrote: > On Wednesday, 9 May 2007 10:59, Thomas Gleixner wrote: > > On Wed, 2007-05-09 at 01:31 -0700, Andrew Morton wrote: > > > > I suspect I just tested the wrong thing yesterday. Let me recheck just > > > > these patches against 2.6.21. > > >

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Thomas Gleixner
On Wed, 2007-05-09 at 13:45 +0200, Rafael J. Wysocki wrote: > On Wednesday, 9 May 2007 10:59, Thomas Gleixner wrote: > > On Wed, 2007-05-09 at 01:31 -0700, Andrew Morton wrote: > > > > I suspect I just tested the wrong thing yesterday. Let me recheck just > > > > these patches against 2.6.21. > >

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Rafael J. Wysocki
On Wednesday, 9 May 2007 10:59, Thomas Gleixner wrote: > On Wed, 2007-05-09 at 01:31 -0700, Andrew Morton wrote: > > > I suspect I just tested the wrong thing yesterday. Let me recheck just > > > these patches against 2.6.21. > > > > yup, same hang with just these three: > > > > origin > > clock

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Thomas Gleixner
On Wed, 2007-05-09 at 01:31 -0700, Andrew Morton wrote: > > I suspect I just tested the wrong thing yesterday. Let me recheck just > > these patches against 2.6.21. > > yup, same hang with just these three: > > origin > clocksource-fix-resume-logic > clockevents-fix-resume-logic-updated-version

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Andrew Morton
On Wed, 9 May 2007 01:22:57 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 09 May 2007 10:18:17 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > On Wed, 2007-05-09 at 00:10 -0700, Andrew Morton wrote: > > > > > find an updated patch below. It fixes the problem on Ingo's > > > > >

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Andrew Morton
On Wed, 09 May 2007 10:18:17 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Wed, 2007-05-09 at 00:10 -0700, Andrew Morton wrote: > > > > find an updated patch below. It fixes the problem on Ingo's > > > > VAIO-of-fun-emulator and I got confirmation from several other affected > > > > users,

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Thomas Gleixner
On Wed, 2007-05-09 at 00:10 -0700, Andrew Morton wrote: > > > find an updated patch below. It fixes the problem on Ingo's > > > VAIO-of-fun-emulator and I got confirmation from several other affected > > > users, that the patch series is still solving their problems. > > > > > > > The machine is

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-09 Thread Andrew Morton
On Tue, 8 May 2007 22:59:20 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sun, 06 May 2007 17:03:03 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > > > Andrew, > > > > On Sat, 2007-05-05 at 13:51 +0200, Ingo Molnar wrote: > > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > > >

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-08 Thread Andrew Morton
On Sun, 06 May 2007 17:03:03 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > Andrew, > > On Sat, 2007-05-05 at 13:51 +0200, Ingo Molnar wrote: > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > Fixup the existing users. > > > > > > This one makes the Vaio-of-fun hang during suspend t

Re: [patch 3/3] clockevents: Fix resume logic - updated version

2007-05-08 Thread Andrew Morton
On Sun, 06 May 2007 17:03:03 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Sat, 2007-05-05 at 13:51 +0200, Ingo Molnar wrote: > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > Fixup the existing users. > > > > > > This one makes the Vaio-of-fun hang during suspend to disk. It g

[patch 3/3] clockevents: Fix resume logic - updated version

2007-05-06 Thread Thomas Gleixner
Andrew, On Sat, 2007-05-05 at 13:51 +0200, Ingo Molnar wrote: > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > Fixup the existing users. > > > > This one makes the Vaio-of-fun hang during suspend to disk. It gets > > up to "swsusp: critical section/: done (%d pages copied)" then it > > fr

Re: [patch 3/3] clockevents: Fix resume logic

2007-05-05 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > > Fixup the existing users. > > This one makes the Vaio-of-fun hang during suspend to disk. It gets > up to "swsusp: critical section/: done (%d pages copied)" then it > freezes. after trying to reproduce it on 2 boxes without success it did trigg

Re: [patch 3/3] clockevents: Fix resume logic

2007-05-05 Thread Andrew Morton
On Mon, 30 Apr 2007 10:43:34 - Thomas Gleixner <[EMAIL PROTECTED]> wrote: > We need to make sure, that the clockevent devices are resumed, before > the tick is resumed. The current resume logic does not guarantee this. > > Add CLOCK_EVT_MODE_RESUME and call the set mode functions of the clock