Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-18 13:28-0200, Marcelo Tosatti: > On Wed, Jan 18, 2017 at 04:20:33PM +0100, Radim Krcmar wrote: >> 2017-01-18 12:53-0200, Marcelo Tosatti: >> > GOn Wed, Jan 18, 2017 at 12:37:25PM -0200, Marcelo Tosatti wrote: >> > > On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: >> > > > >

Re: [patch 3/3] PTP: add kvm PTP driver

On Wed, Jan 18, 2017 at 04:45:07PM +0100, Paolo Bonzini wrote: > > > On 18/01/2017 15:50, Marcelo Tosatti wrote: > >> Interesting idea! For this to work, KVM needs to implement > >> getcrosstimestamp and ptp_chardev.c can then add an alternative > >> implementation of PTP_SYS_OFFSET, based on pr

Re: [patch 3/3] PTP: add kvm PTP driver

On Wed, Jan 18, 2017 at 04:20:33PM +0100, Radim Krcmar wrote: > 2017-01-18 12:53-0200, Marcelo Tosatti: > > GOn Wed, Jan 18, 2017 at 12:37:25PM -0200, Marcelo Tosatti wrote: > > > On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: > > > > > > > > > > > > On 18/01/2017 13:24, Marcelo T

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-18 16:54+0100, Miroslav Lichvar: > On Wed, Jan 18, 2017 at 12:24:09PM -0200, Marcelo Tosatti wrote: >> On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: >> > I'd rather use PTP_SYS_OFFSET_PRECISE instead, but unfortunately chrony >> > does not support it---but I would still pre

Re: [patch 3/3] PTP: add kvm PTP driver

On 18/01/2017 16:54, Miroslav Lichvar wrote: >> Sure, I'll check if it makes sense to implement PTP_SYS_OFFSET_PRECISE for >> KVM case. > But is it really so precise that the application can safely assume > there are no errors due to asymmetric delays, etc? I think > PTP_SYS_OFFSET_PRECISE shoul

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-18 13:46+0100, Paolo Bonzini: > > > On 18/01/2017 13:24, Marcelo Tosatti wrote: > > On Wed, Jan 18, 2017 at 10:17:38AM -0200, Marcelo Tosatti wrote: > >> On Tue, Jan 17, 2017 at 04:36:21PM +0100, Radim Krcmar wrote: > >>> 2017-01-17 09:30-0200, Marcelo Tosatti: > On Tue, Jan 17, 2017

Re: [patch 3/3] PTP: add kvm PTP driver

On Wed, Jan 18, 2017 at 12:24:09PM -0200, Marcelo Tosatti wrote: > On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: > > I'd rather use PTP_SYS_OFFSET_PRECISE instead, but unfortunately chrony > > does not support it---but I would still prefer you to support > > PTP_SYS_OFFSET_PRECISE

Re: [patch 3/3] PTP: add kvm PTP driver

On 18/01/2017 15:50, Marcelo Tosatti wrote: >> Interesting idea! For this to work, KVM needs to implement >> getcrosstimestamp and ptp_chardev.c can then add an alternative >> implementation of PTP_SYS_OFFSET, based on precise cross timestamps. >> >> Something like >> >> for (i =

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-18 12:50-0200, Marcelo Tosatti: > On Wed, Jan 18, 2017 at 03:02:23PM +0100, Paolo Bonzini wrote: >> >> >> On 18/01/2017 14:36, Miroslav Lichvar wrote: >> > On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: >> >> On 18/01/2017 13:24, Marcelo Tosatti wrote: >> Testcase: ru

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-18 12:53-0200, Marcelo Tosatti: > GOn Wed, Jan 18, 2017 at 12:37:25PM -0200, Marcelo Tosatti wrote: > > On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: > > > > > > > > > On 18/01/2017 13:24, Marcelo Tosatti wrote: > > > > On Wed, Jan 18, 2017 at 10:17:38AM -0200, Marcelo To

Re: [patch 3/3] PTP: add kvm PTP driver

On Wed, Jan 18, 2017 at 03:02:23PM +0100, Paolo Bonzini wrote: > > > On 18/01/2017 14:36, Miroslav Lichvar wrote: > > On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: > >> On 18/01/2017 13:24, Marcelo Tosatti wrote: > Testcase: run a guest and a loop sending SIGUSR1 to vcpu0 (e

Re: [patch 3/3] PTP: add kvm PTP driver

GOn Wed, Jan 18, 2017 at 12:37:25PM -0200, Marcelo Tosatti wrote: > On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: > > > > > > On 18/01/2017 13:24, Marcelo Tosatti wrote: > > > On Wed, Jan 18, 2017 at 10:17:38AM -0200, Marcelo Tosatti wrote: > > >> On Tue, Jan 17, 2017 at 04:36:21

Re: [patch 3/3] PTP: add kvm PTP driver

On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: > On 18/01/2017 13:24, Marcelo Tosatti wrote: > > On Wed, Jan 18, 2017 at 10:17:38AM -0200, Marcelo Tosatti wrote: > >> On Tue, Jan 17, 2017 at 04:36:21PM +0100, Radim Krcmar wrote: > >>> 2017-01-17 09:30-0200, Marcelo Tosatti: > O

Re: [patch 3/3] PTP: add kvm PTP driver

On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: > > > On 18/01/2017 13:24, Marcelo Tosatti wrote: > > On Wed, Jan 18, 2017 at 10:17:38AM -0200, Marcelo Tosatti wrote: > >> On Tue, Jan 17, 2017 at 04:36:21PM +0100, Radim Krcmar wrote: > >>> 2017-01-17 09:30-0200, Marcelo Tosatti: >

Re: [patch 3/3] PTP: add kvm PTP driver

On 18/01/2017 14:36, Miroslav Lichvar wrote: > On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: >> On 18/01/2017 13:24, Marcelo Tosatti wrote: Testcase: run a guest and a loop sending SIGUSR1 to vcpu0 (emulating intense interrupts). Follows results: > Do you still wa

Re: [patch 3/3] PTP: add kvm PTP driver

On Wed, Jan 18, 2017 at 01:46:58PM +0100, Paolo Bonzini wrote: > On 18/01/2017 13:24, Marcelo Tosatti wrote: > >> Testcase: run a guest and a loop sending SIGUSR1 to vcpu0 (emulating > >> intense interrupts). Follows results: > >> Do you still want to drop it in favour of simplicity? > It's just

Re: [patch 3/3] PTP: add kvm PTP driver

On 18/01/2017 13:24, Marcelo Tosatti wrote: > On Wed, Jan 18, 2017 at 10:17:38AM -0200, Marcelo Tosatti wrote: >> On Tue, Jan 17, 2017 at 04:36:21PM +0100, Radim Krcmar wrote: >>> 2017-01-17 09:30-0200, Marcelo Tosatti: On Tue, Jan 17, 2017 at 09:03:27AM +0100, Miroslav Lichvar wrote: >

Re: [patch 3/3] PTP: add kvm PTP driver

On Wed, Jan 18, 2017 at 10:17:38AM -0200, Marcelo Tosatti wrote: > On Tue, Jan 17, 2017 at 04:36:21PM +0100, Radim Krcmar wrote: > > 2017-01-17 09:30-0200, Marcelo Tosatti: > > > On Tue, Jan 17, 2017 at 09:03:27AM +0100, Miroslav Lichvar wrote: > > >> On Mon, Jan 16, 2017 at 06:01:14PM -0200, Marce

Re: [patch 3/3] PTP: add kvm PTP driver

On Tue, Jan 17, 2017 at 04:36:21PM +0100, Radim Krcmar wrote: > 2017-01-17 09:30-0200, Marcelo Tosatti: > > On Tue, Jan 17, 2017 at 09:03:27AM +0100, Miroslav Lichvar wrote: > >> On Mon, Jan 16, 2017 at 06:01:14PM -0200, Marcelo Tosatti wrote: > >> > On Mon, Jan 16, 2017 at 05:47:15PM -0200, Marcel

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-17 09:30-0200, Marcelo Tosatti: > On Tue, Jan 17, 2017 at 09:03:27AM +0100, Miroslav Lichvar wrote: >> On Mon, Jan 16, 2017 at 06:01:14PM -0200, Marcelo Tosatti wrote: >> > On Mon, Jan 16, 2017 at 05:47:15PM -0200, Marcelo Tosatti wrote: >> > > On Mon, Jan 16, 2017 at 05:36:55PM -0200, Marc

Re: [patch 3/3] PTP: add kvm PTP driver

On Tue, Jan 17, 2017 at 09:03:27AM +0100, Miroslav Lichvar wrote: > On Mon, Jan 16, 2017 at 06:01:14PM -0200, Marcelo Tosatti wrote: > > On Mon, Jan 16, 2017 at 05:47:15PM -0200, Marcelo Tosatti wrote: > > > On Mon, Jan 16, 2017 at 05:36:55PM -0200, Marcelo Tosatti wrote: > > > > Sorry, unless i am

Re: [patch 3/3] PTP: add kvm PTP driver

On Mon, Jan 16, 2017 at 06:01:14PM -0200, Marcelo Tosatti wrote: > On Mon, Jan 16, 2017 at 05:47:15PM -0200, Marcelo Tosatti wrote: > > On Mon, Jan 16, 2017 at 05:36:55PM -0200, Marcelo Tosatti wrote: > > > Sorry, unless i am misunderstanding how this works, it'll get the guest > > > clock > > > 2

Re: [patch 3/3] PTP: add kvm PTP driver

On Mon, Jan 16, 2017 at 05:47:15PM -0200, Marcelo Tosatti wrote: > On Mon, Jan 16, 2017 at 05:36:55PM -0200, Marcelo Tosatti wrote: > > On Mon, Jan 16, 2017 at 07:01:48PM +0100, Radim Krcmar wrote: > > > > Sorry the clock difference is 10ns now. So the guest clock is off by > > > > _10 ns_ > > >

Re: [patch 3/3] PTP: add kvm PTP driver

On Mon, Jan 16, 2017 at 05:36:55PM -0200, Marcelo Tosatti wrote: > On Mon, Jan 16, 2017 at 07:01:48PM +0100, Radim Krcmar wrote: > > > Sorry the clock difference is 10ns now. So the guest clock is off by _10 > > > ns_ > > > of the host clock. > > > > That is pretty good. > > Yes. > > > > You a

Re: [patch 3/3] PTP: add kvm PTP driver

On Mon, Jan 16, 2017 at 07:01:48PM +0100, Radim Krcmar wrote: > > Sorry the clock difference is 10ns now. So the guest clock is off by _10 > > ns_ > > of the host clock. > > That is pretty good. Yes. > > You are suggesting to use getcrosststamp instead, to drop the (rdtsc() - > > guest_tsc) pa

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-16 15:39-0200, Marcelo Tosatti: > On Mon, Jan 16, 2017 at 06:27:58PM +0100, Radim Krcmar wrote: >> 2017-01-16 15:08-0200, Marcelo Tosatti: >> > On Mon, Jan 16, 2017 at 05:54:11PM +0100, Radim Krcmar wrote: >> >> 2017-01-16 17:26+0100, Radim Krcmar: >> >> > 2017-01-13 15:40-0200, Marcelo Tos

Re: [patch 3/3] PTP: add kvm PTP driver

On Mon, Jan 16, 2017 at 06:27:58PM +0100, Radim Krcmar wrote: > 2017-01-16 15:08-0200, Marcelo Tosatti: > > On Mon, Jan 16, 2017 at 05:54:11PM +0100, Radim Krcmar wrote: > >> 2017-01-16 17:26+0100, Radim Krcmar: > >> > 2017-01-13 15:40-0200, Marcelo Tosatti: > >> >> On Fri, Jan 13, 2017 at 04:56:58

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-16 15:04-0200, Marcelo Tosatti: > On Mon, Jan 16, 2017 at 05:26:53PM +0100, Radim Krcmar wrote: >> 2017-01-13 15:40-0200, Marcelo Tosatti: >> > On Fri, Jan 13, 2017 at 04:56:58PM +0100, Radim Krcmar wrote: >> > > 2017-01-13 10:01-0200, Marcelo Tosatti: >> >> > + version = pvcl

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-16 15:08-0200, Marcelo Tosatti: > On Mon, Jan 16, 2017 at 05:54:11PM +0100, Radim Krcmar wrote: >> 2017-01-16 17:26+0100, Radim Krcmar: >> > 2017-01-13 15:40-0200, Marcelo Tosatti: >> >> On Fri, Jan 13, 2017 at 04:56:58PM +0100, Radim Krcmar wrote: >> >> > 2017-01-13 10:01-0200, Marcelo Tos

Re: [patch 3/3] PTP: add kvm PTP driver

On Mon, Jan 16, 2017 at 05:54:11PM +0100, Radim Krcmar wrote: > 2017-01-16 17:26+0100, Radim Krcmar: > > 2017-01-13 15:40-0200, Marcelo Tosatti: > >> On Fri, Jan 13, 2017 at 04:56:58PM +0100, Radim Krcmar wrote: > >> > 2017-01-13 10:01-0200, Marcelo Tosatti: > >>> > + version = pvcloc

Re: [patch 3/3] PTP: add kvm PTP driver

On Mon, Jan 16, 2017 at 05:26:53PM +0100, Radim Krcmar wrote: > 2017-01-13 15:40-0200, Marcelo Tosatti: > > On Fri, Jan 13, 2017 at 04:56:58PM +0100, Radim Krcmar wrote: > > > 2017-01-13 10:01-0200, Marcelo Tosatti: > >> > +version = pvclock_read_begin(src); > >> > + > >> > +

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-16 17:26+0100, Radim Krcmar: > 2017-01-13 15:40-0200, Marcelo Tosatti: >> On Fri, Jan 13, 2017 at 04:56:58PM +0100, Radim Krcmar wrote: >> > 2017-01-13 10:01-0200, Marcelo Tosatti: >>> > + version = pvclock_read_begin(src); >>> > + >>> > + ret = kvm_hypercall2(KVM_HC_CLOCK_O

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-13 15:40-0200, Marcelo Tosatti: > On Fri, Jan 13, 2017 at 04:56:58PM +0100, Radim Krcmar wrote: > > 2017-01-13 10:01-0200, Marcelo Tosatti: >> > + version = pvclock_read_begin(src); >> > + >> > + ret = kvm_hypercall2(KVM_HC_CLOCK_OFFSET, >> > +

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-14 16:26+0100, Richard Cochran: > On Fri, Jan 13, 2017 at 04:56:58PM +0100, Radim Krcmar wrote: >> > +static int __init ptp_kvm_init(void) >> > +{ >> > + if (!kvm_para_available()) >> > + return -ENODEV; >> > + >> > + kvm_ptp_clock.caps = ptp_kvm_caps; >> > + >> > + kvm_ptp_cloc

Re: [patch 3/3] PTP: add kvm PTP driver

On Fri, Jan 13, 2017 at 04:56:58PM +0100, Radim Krcmar wrote: > > +static int __init ptp_kvm_init(void) > > +{ > > + if (!kvm_para_available()) > > + return -ENODEV; > > + > > + kvm_ptp_clock.caps = ptp_kvm_caps; > > + > > + kvm_ptp_clock.ptp_clock = ptp_clock_register(&kvm_ptp_cloc

[patch 3/3] PTP: add kvm PTP driver

Add a driver with gettime method returning hosts realtime clock. This allows Chrony to synchronize host and guest clocks with high precision (see results below). chronyc> sources MS Name/IP address Stratum Poll Reach LastRx Last sample =

Re: [patch 3/3] PTP: add kvm PTP driver

On Fri, Jan 13, 2017 at 04:56:58PM +0100, Radim Krcmar wrote: > 2017-01-13 10:01-0200, Marcelo Tosatti: > > Add a driver with gettime method returning hosts realtime clock. > > This allows Chrony to synchronize host and guest clocks with > > high precision (see results below). > > > > chronyc> so

Re: [patch 3/3] PTP: add kvm PTP driver

2017-01-13 10:01-0200, Marcelo Tosatti: > Add a driver with gettime method returning hosts realtime clock. > This allows Chrony to synchronize host and guest clocks with > high precision (see results below). > > chronyc> sources > MS Name/IP address Stratum Poll Reach LastRx Last sample >

[patch 3/3] PTP: add kvm PTP driver

Add a driver with gettime method returning hosts realtime clock. This allows Chrony to synchronize host and guest clocks with high precision (see results below). chronyc> sources MS Name/IP address Stratum Poll Reach LastRx Last sample =