> > +
> > + err = xenbus_printf(xbt, dev->nodename,
> > + "ring-ref","%u", info->ring_ref);
>
> why do you need your own printf?
xenbus_printf isn't a printf replacement - it is used for writing a formatted
string into XenStore (which contains VM configuration data in a
On 14/1/07 11:05 am, "Jan Engelhardt" <[EMAIL PROTECTED]> wrote:
>> The block device frontend driver allows the kernel to access block
>> devices exported exported by a virtual machine containing a physical
>> block device driver.
>
> Is this significantly different from ubd/hostfs that it actual
On Jan 14 2007 13:24, Muli Ben-Yehuda wrote:
>On Sun, Jan 14, 2007 at 12:05:13PM +0100, Jan Engelhardt wrote:
>
>> >+ (void)xenbus_switch_state(info->xbdev, XenbusStateConnected);
>>
>> Cast remove, if xenbus_switch_state does not have __must_check.
>> Also elsewhere.
>
>Hmm, why? this way you
On Sun, Jan 14, 2007 at 12:05:13PM +0100, Jan Engelhardt wrote:
> >+(void)xenbus_switch_state(info->xbdev, XenbusStateConnected);
>
> Cast remove, if xenbus_switch_state does not have __must_check.
> Also elsewhere.
Hmm, why? this way you know that the programmer isn't checking the
return va
On Jan 12 2007 17:45, Jeremy Fitzhardinge wrote:
>
>The block device frontend driver allows the kernel to access block
>devices exported exported by a virtual machine containing a physical
>block device driver.
Is this significantly different from ubd/hostfs that it actually warrants a
reinventio
On Sat, Jan 13, 2007 at 05:07:28PM -0800, Arjan van de Ven wrote:
> > +
> > +#define DPRINTK(_f, _a...) pr_debug(_f, ## _a)
>
> why this silly abstraction? Just use pr_debug in the code directly
Actually, for drivers, like this one, you should use the dev_printk()
and friends (dev_dbg, dev_err, e
> +#include "../../../arch/i386/paravirt-xen/events.h"
> +#include "../../../arch/i386/paravirt-xen/xen-page.h"
this shows the headers are clearly in the wrong place...
> +
> + err = xenbus_printf(xbt, dev->nodename,
> + "ring-ref","%u", info->ring_ref);
why do you nee
The block device frontend driver allows the kernel to access block
devices exported exported by a virtual machine containing a physical
block device driver.
Signed-off-by: Ian Pratt <[EMAIL PROTECTED]>
Signed-off-by: Christian Limpach <[EMAIL PROTECTED]>
Signed-off-by: Chris Wright <[EMAIL PROTECT
8 matches
Mail list logo
