Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix

2007-10-20 Thread Sam Ravnborg
> > > Is it truly protable with "=" or do we need to be more clever? > > I don't know how you managed to get it to work wtih "==". > String equality should be "=" in all /bin/sh versions. > It's been that way since it was written in pseudo-Algol. [EMAIL PROTECTED] kbuild.git]$ if [ "x86_64" == "

Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix

2007-10-19 Thread David Brownell
> > - if [ -r System.map -a -x $(DEPMOD) -a "$(SUBARCH)" == "$(ARCH)" ]; then > > \ > > + if [ -r System.map -a -x $(DEPMOD) -a "$(SUBARCH)" = "$(ARCH)" ]; then \ > > Took a look at 'man bash' here. > bash --version > GNU bash, version 3.2.9(1)-release (x86_64-redhat-linux-gnu) > Copyright (C)

Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix

2007-10-19 Thread Roland Dreier
> Accoding to man bash "==" is used to test for equality and "=" is used for > assignmnet. > I assume the above is a dash syntax error (dash is default on ubuntu IIRC). My bash man page says the following under "CONDITIONAL EXPRESSIONS": string1 == string2 True if the str

Re: [patch 2.6.23-git] toplevel Makefile/depmod bugfix

2007-10-19 Thread Sam Ravnborg
On Fri, Oct 19, 2007 at 09:42:24PM -0700, David Brownell wrote: > This removes a BASH syntax error (seen building on Ubuntu Feisty). > > Signed-off-by: David Brownell <[EMAIL PROTECTED]> > > --- g26.orig/Makefile 2007-10-19 21:29:43.0 -0700 > +++ g26/Makefile 2007-10-19 18:35:32.

[patch 2.6.23-git] toplevel Makefile/depmod bugfix

2007-10-19 Thread David Brownell
This removes a BASH syntax error (seen building on Ubuntu Feisty). Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- g26.orig/Makefile 2007-10-19 21:29:43.0 -0700 +++ g26/Makefile2007-10-19 18:35:32.0 -0700 @@ -1507,7 +1507,7 @@ quiet_cmd_rmfiles = $(if $(wildcard $(