Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-30 Thread Russell King
On Sat, Dec 30, 2006 at 02:59:39PM +0100, pHilipp Zabel wrote: > --- linux-2.6.orig/arch/arm/mach-sa1100/generic.c 2006-12-27 > 21:50:03.0 +0100 > +++ linux-2.6/arch/arm/mach-sa1100/generic.c 2006-12-30 > 14:50:42.0 +0100 > @@ -138,6 +138,36 @@ > return v; > } > > +int

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-30 Thread pHilipp Zabel
On 12/30/06, David Brownell <[EMAIL PROTECTED]> wrote: On Friday 29 December 2006 7:15 pm, Nicolas Pitre wrote: > On Fri, 29 Dec 2006, David Brownell wrote: > > > Here's a version that compiles ... > > This patch is completely broken. It's just what Philipp sent, with the "won't compile" bugs fi

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-29 Thread David Brownell
On Friday 29 December 2006 7:15 pm, Nicolas Pitre wrote: > On Fri, 29 Dec 2006, David Brownell wrote: > > > Here's a version that compiles ... > > This patch is completely broken. It's just what Philipp sent, with the "won't compile" bugs fixed. Oh, and some #include tweaks. Philipp? > > Arch

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-29 Thread Nicolas Pitre
On Fri, 29 Dec 2006, David Brownell wrote: > Here's a version that compiles ... This patch is completely broken. > Arch-neutral GPIO calls for PXA. This is not PXA but SA1100 to start with. > Signed-off-by: David Brownell <[EMAIL PROTECTED]> > > Index: pxa/include/asm-arm/arch-sa1100/gpio.h >

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-29 Thread David Brownell
Here's a version that compiles ... From: Philipp Zabel <[EMAIL PROTECTED]> Arch-neutral GPIO calls for PXA. Signed-off-by: David Brownell <[EMAIL PROTECTED]> Index: pxa/include/asm-arm/arch-sa1100/gpio.h === --- /dev/null 1970-01-01

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-28 Thread Pavel Machek
Hi! > +static inline int gpio_direction_input(unsigned gpio) > +{ > + if (gpio > GPIO_MAX) > + return -EINVAL; > + GPDR = (GPDR_In << gpio) 0 > +} Missing return 0. > +static inline int gpio_direction_output(unsigned gpio) > +{ > + if (gpio > GPIO_MAX) > + ret

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-23 Thread David Brownell
On Saturday 23 December 2006 3:37 am, Russell King wrote: > Why do we need to convert between IRQ and PGIO numbers? (I take it that's the only real issue you had with this patch, other than maybe excessive #includes?) I suppose we could do with a one way mapping: GPIO-to-IRQ, then require driv

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-23 Thread Russell King
On Wed, Dec 20, 2006 at 01:13:21PM -0800, David Brownell wrote: > Arch-neutral GPIO calls for SA-1100. > > From: Philipp Zabel <[EMAIL PROTECTED]> > > +static inline unsigned gpio_to_irq(unsigned gpio) > +{ > + if (gpio < 11) > + return IRQ_GPIO0 + gpio; > + else > +

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-22 Thread Nicolas Pitre
On Fri, 22 Dec 2006, pHilipp Zabel wrote: > On 12/21/06, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Wed, 20 Dec 2006 13:13:21 -0800 > > David Brownell <[EMAIL PROTECTED]> wrote: > > > > > +#define gpio_get_value(gpio) \ > > > + (GPLR & GPIO_GPIO(gpio)) > > > + > > > +#define gpio_set_valu

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-21 Thread pHilipp Zabel
On 12/21/06, Andrew Morton <[EMAIL PROTECTED]> wrote: On Wed, 20 Dec 2006 13:13:21 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > +#define gpio_get_value(gpio) \ > + (GPLR & GPIO_GPIO(gpio)) > + > +#define gpio_set_value(gpio,value) \ > + ((value) ? (GPSR = GPIO_GPIO(gpio)) : (GPCR(gp

Re: [patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-20 Thread Andrew Morton
On Wed, 20 Dec 2006 13:13:21 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > +#define gpio_get_value(gpio) \ > + (GPLR & GPIO_GPIO(gpio)) > + > +#define gpio_set_value(gpio,value) \ > + ((value) ? (GPSR = GPIO_GPIO(gpio)) : (GPCR(gpio) = GPIO_GPIO(gpio))) likewise. - To unsubscribe from

[patch 2.6.20-rc1 5/6] SA1100 GPIO wrappers

2006-12-20 Thread David Brownell
Arch-neutral GPIO calls for SA-1100. From: Philipp Zabel <[EMAIL PROTECTED]> Index: at91/include/asm-arm/arch-sa1100/gpio.h === --- /dev/null 1970-01-01 00:00:00.0 + +++ at91/include/asm-arm/arch-sa1100/gpio.h 2006-