Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0

2005-07-27 Thread John W. Linville
On Tue, Jul 26, 2005 at 09:36:02PM -0400, John W. Linville wrote: > On Tue, Jul 26, 2005 at 04:49:34PM -0700, Greg KH wrote: > > This code doesn't even build, as need_restore isn't a global variable. > > Hmmm...you must be missing this hunk from the patch posted on July 8? > > Care to redo this

Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0

2005-07-26 Thread John W. Linville
On Tue, Jul 26, 2005 at 04:49:34PM -0700, Greg KH wrote: > On Fri, Jul 08, 2005 at 02:34:56PM -0400, John W. Linville wrote: > > @@ -301,6 +335,16 @@ pci_set_power_state(struct pci_dev *dev, > > udelay(200); > > dev->current_state = state; > > > > + /* According to section 5.4.1

Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0

2005-07-26 Thread Greg KH
On Fri, Jul 08, 2005 at 02:34:56PM -0400, John W. Linville wrote: > @@ -301,6 +335,16 @@ pci_set_power_state(struct pci_dev *dev, > udelay(200); > dev->current_state = state; > > + /* According to section 5.4.1 of the "PCI BUS POWER MANAGEMENT > + * INTERFACE SPECIFIC

Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0

2005-07-13 Thread John W. Linville
On Mon, Jul 11, 2005 at 10:28:55PM -0400, Adam Belay wrote: > On Fri, Jul 08, 2005 at 02:34:56PM -0400, John W. Linville wrote: > > Some firmware leaves devices in D3hot after a (re)boot. Most drivers > > call pci_enable_device very early, so devices left in D3hot that lose > > configuration duri

Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0

2005-07-11 Thread Adam Belay
On Fri, Jul 08, 2005 at 02:34:56PM -0400, John W. Linville wrote: > Some PCI devices lose all configuration (including BARs) when > transitioning from D3hot->D0. This leaves such a device in an > inaccessible state. The patch below causes the BARs to be restored > when enabling such a device, so

Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0

2005-07-11 Thread John W. Linville
On Mon, Jul 11, 2005 at 02:48:44PM +0200, Lennert Buytenhek wrote: > On Fri, Jul 08, 2005 at 02:34:56PM -0400, John W. Linville wrote: > > > Some PCI devices lose all configuration (including BARs) when > > transitioning from D3hot->D0. This leaves such a device in an > > inaccessible state. The

Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0

2005-07-11 Thread Lennert Buytenhek
On Fri, Jul 08, 2005 at 02:34:56PM -0400, John W. Linville wrote: > Some PCI devices lose all configuration (including BARs) when > transitioning from D3hot->D0. This leaves such a device in an > inaccessible state. The patch below causes the BARs to be restored > when enabling such a device, so

Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0

2005-07-10 Thread Ivan Kokshaysky
On Fri, Jul 08, 2005 at 02:34:56PM -0400, John W. Linville wrote: > Some PCI devices lose all configuration (including BARs) when > transitioning from D3hot->D0. This leaves such a device in an > inaccessible state. The patch below causes the BARs to be restored > when enabling such a device, so

Re: [patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0

2005-07-08 Thread David S. Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Fri, 8 Jul 2005 14:34:56 -0400 > The cleanest implementation of pci_restore_bars was to call > pci_update_resource. Unfortunately, that does not currently exist > for the sparc64 architecture. The patch below includes a stub > implemenation of p

[patch 2.6.13-rc2] pci: restore BAR values from pci_set_power_state for D3hot->D0

2005-07-08 Thread John W. Linville
Some PCI devices lose all configuration (including BARs) when transitioning from D3hot->D0. This leaves such a device in an inaccessible state. The patch below causes the BARs to be restored when enabling such a device, so that its driver will be able to access it. Signed-off-by: John W. Linvill