Re: [patch 10/10] mm: workingset: keep shadow entries in check

2013-06-06 Thread Johannes Weiner
On Mon, Jun 03, 2013 at 07:10:31PM +0200, Peter Zijlstra wrote: > On Mon, Jun 03, 2013 at 11:01:54AM -0400, Johannes Weiner wrote: > > On Mon, Jun 03, 2013 at 10:22:09AM +0200, Peter Zijlstra wrote: > > > On Thu, May 30, 2013 at 02:04:06PM -0400, Johannes Weiner wrote: > > > > 2. a list of files th

Re: [patch 10/10] mm: workingset: keep shadow entries in check

2013-06-03 Thread Peter Zijlstra
On Mon, Jun 03, 2013 at 02:12:02PM -0400, Johannes Weiner wrote: > > But given that, sure maybe 1 memory size is a bit strict, but surely we > > can put a limit on things at about 2 memory sizes? > > That's what this 10/10 patch does (prune everything older than 2 * > global_dirtyable_memory()), s

Re: [patch 10/10] mm: workingset: keep shadow entries in check

2013-06-03 Thread Johannes Weiner
On Mon, Jun 03, 2013 at 07:15:58PM +0200, Peter Zijlstra wrote: > On Mon, Jun 03, 2013 at 11:20:32AM -0400, Johannes Weiner wrote: > > On Mon, Jun 03, 2013 at 10:25:33AM +0200, Peter Zijlstra wrote: > > > On Thu, May 30, 2013 at 02:04:06PM -0400, Johannes Weiner wrote: > > > > Previously, page cach

Re: [patch 10/10] mm: workingset: keep shadow entries in check

2013-06-03 Thread Peter Zijlstra
On Mon, Jun 03, 2013 at 11:20:32AM -0400, Johannes Weiner wrote: > On Mon, Jun 03, 2013 at 10:25:33AM +0200, Peter Zijlstra wrote: > > On Thu, May 30, 2013 at 02:04:06PM -0400, Johannes Weiner wrote: > > > Previously, page cache radix tree nodes were freed after reclaim > > > emptied out their page

Re: [patch 10/10] mm: workingset: keep shadow entries in check

2013-06-03 Thread Peter Zijlstra
On Mon, Jun 03, 2013 at 11:01:54AM -0400, Johannes Weiner wrote: > On Mon, Jun 03, 2013 at 10:22:09AM +0200, Peter Zijlstra wrote: > > On Thu, May 30, 2013 at 02:04:06PM -0400, Johannes Weiner wrote: > > > 2. a list of files that contain shadow entries is maintained. If the > > >global number

Re: [patch 10/10] mm: workingset: keep shadow entries in check

2013-06-03 Thread Johannes Weiner
On Mon, Jun 03, 2013 at 10:25:33AM +0200, Peter Zijlstra wrote: > On Thu, May 30, 2013 at 02:04:06PM -0400, Johannes Weiner wrote: > > Previously, page cache radix tree nodes were freed after reclaim > > emptied out their page pointers. But now reclaim stores shadow > > entries in their place, whi

Re: [patch 10/10] mm: workingset: keep shadow entries in check

2013-06-03 Thread Johannes Weiner
On Mon, Jun 03, 2013 at 10:22:09AM +0200, Peter Zijlstra wrote: > On Thu, May 30, 2013 at 02:04:06PM -0400, Johannes Weiner wrote: > > 2. a list of files that contain shadow entries is maintained. If the > >global number of shadows exceeds a certain threshold, a shrinker is > >activated th

Re: [patch 10/10] mm: workingset: keep shadow entries in check

2013-06-03 Thread Peter Zijlstra
On Thu, May 30, 2013 at 02:04:06PM -0400, Johannes Weiner wrote: > Previously, page cache radix tree nodes were freed after reclaim > emptied out their page pointers. But now reclaim stores shadow > entries in their place, which are only reclaimed when the inodes > themselves are reclaimed. This

Re: [patch 10/10] mm: workingset: keep shadow entries in check

2013-06-03 Thread Peter Zijlstra
On Thu, May 30, 2013 at 02:04:06PM -0400, Johannes Weiner wrote: > 2. a list of files that contain shadow entries is maintained. If the >global number of shadows exceeds a certain threshold, a shrinker is >activated that reclaims old entries from the mappings. This is >heavy-handed bu

[patch 10/10] mm: workingset: keep shadow entries in check

2013-05-30 Thread Johannes Weiner
Previously, page cache radix tree nodes were freed after reclaim emptied out their page pointers. But now reclaim stores shadow entries in their place, which are only reclaimed when the inodes themselves are reclaimed. This is problematic for bigger files that are still in use after they have a s