reviewed (Re: [patch 1/7] Extended crashkernel command line)

Wed, Sep 26, 2007 at 11:05:33PM +0200, Bernhard Walle: > * Oleg Verych <[EMAIL PROTECTED]> [2007-09-26 20:18]: > > > > > > --- a/kernel/kexec.c > > > +++ b/kernel/kexec.c > > > @@ -1172,33 +1172,50 @@ static int __init parse_crashkernel_mem( > > > do { > > > unsigned long long start =

Re: [patch 1/7] Extended crashkernel command line

* Oleg Verych <[EMAIL PROTECTED]> [2007-09-26 20:18]: > > > > --- a/kernel/kexec.c > > +++ b/kernel/kexec.c > > @@ -1172,33 +1172,50 @@ static int __init parse_crashkernel_mem( > > do { > > unsigned long long start = 0, end = ULLONG_MAX; > > unsigned long long size = -1

Re: [patch 1/7] Extended crashkernel command line

* Oleg Verych <[EMAIL PROTECTED]> [2007-09-26 20:18]: > > I was thinking about errors in YaST or typos in bootloader config, that > may appear sometimes. And kernel must tolerate this kind of userspace > input to be more reliable. But you know better, i just am waving hands. Of course the kernel

Re: [patch 1/7] Extended crashkernel command line

Wed, Sep 26, 2007 at 06:16:02PM +0200, Bernhard Walle (part two, see bottom): > > memparse(), as a wrapper for somple_strtoll(), always have a return value > > (zero by default). > > Sorry for my typos, i should write `simple_strtoull()'. This f

Re: [patch 1/7] Extended crashkernel command line

* Oleg Verych <[EMAIL PROTECTED]> [2007-09-25 22:53]: > > > + * > > + * The function returns 0 on success and -EINVAL on failure. > > + */ > > +static int __init parse_crashkernel_mem(char > > *cmdline, > > + unsigned long long system_r

Re: [patch 1/7] Extended crashkernel command line

* Oleg Verych <[EMAIL PROTECTED]> [2007-09-25 22:53]: > * Tue, 25 Sep 2007 20:22:58 +0200 > > > > +++ b/include/linux/kexec.h > > @@ -187,6 +187,8 @@ extern u32 vmcoreinfo_note[VMCOREINFO_NO > > extern size_t vmcoreinfo_size; > > extern size_t vmcoreinfo_max_size; > > > > +int __init parse_cras

Re: [patch 1/7] Extended crashkernel command line

* Tue, 25 Sep 2007 20:22:58 +0200 > > This is the generic part of the patch. It adds a parse_crashkernel() function > in kernel/kexec.c that is called by the architecture specific code that > actually reserves the memory. That function takes the whole command line and > looks itself for "crashkerne

[patch 1/7] Extended crashkernel command line

This is the generic part of the patch. It adds a parse_crashkernel() function in kernel/kexec.c that is called by the architecture specific code that actually reserves the memory. That function takes the whole command line and looks itself for "crashkernel=" in it. If there are multiple occurrence

Re: [patch 1/7] Extended crashkernel command line

* Oleg Verych <[EMAIL PROTECTED]> [2007-09-23 23:15]: > > - crashkernel=512M-2G:64M,2G-:[EMAIL PROTECTED] > + crashkernel=512M-2G,64M,2G-,128M,,offset > ? I don't like this syntax. Thanks, Bernhard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

Re: [patch 1/7] Extended crashkernel command line

On Sun, Sep 23, 2007 at 10:19:43PM +0200, Bernhard Walle wrote: [] > > +int __init get_crashkernel_params(u64 *memsize, u64 *addrbase, char > > *cmdline, u64 ram); > > Andrew, what's your opinion on this? Whould I resend the patch with > shorter type names? Also, maybe it will be better to exte

Re: [patch 1/7] Extended crashkernel command line

* Oleg Verych <[EMAIL PROTECTED]> [2007-09-23 01:14]: > * Thu, 20 Sep 2007 19:18:46 +0200 > > [] > > extern u32 vmcoreinfo_note[VMCOREINFO_NOTE_SIZE/4]; > > extern unsigned int vmcoreinfo_size; > > extern unsigned int vmcoreinfo_max_size; > > +int __init parse_crashkernel(char *cmdline, unsigne

Re: [patch 1/7] Extended crashkernel command line

* Thu, 20 Sep 2007 19:18:46 +0200 [] > extern u32 vmcoreinfo_note[VMCOREINFO_NOTE_SIZE/4]; > extern unsigned int vmcoreinfo_size; > extern unsigned int vmcoreinfo_max_size; > +int __init parse_crashkernel(char *cmdline, unsigned long long system_ram, > + unsigned long long *crash_si

[patch 1/7] Extended crashkernel command line

This is the generic part of the patch. It adds a parse_crashkernel() function in kernel/kexec.c that is called by the architecture specific code that actually reserves the memory. That function takes the whole command line and looks itself for "crashkernel=" in it. If there are multiple occurrence

Re: [patch 1/7] Extended crashkernel command line

On Thu, 13 Sep 2007 18:14:29 +0200 Bernhard Walle <[EMAIL PROTECTED]> wrote: > This is the generic part of the patch. It adds a parse_crashkernel() function > in kernel/kexec.c that is called by the architecture specific code that > actually reserves the memory. That function takes the whole comma

[patch 1/7] Extended crashkernel command line

This is the generic part of the patch. It adds a parse_crashkernel() function in kernel/kexec.c that is called by the architecture specific code that actually reserves the memory. That function takes the whole command line and looks itself for "crashkernel=" in it. If there are multiple occurrence