Re: [patch 1/5] Extended crashkernel command line

2007-09-12 Thread Bernhard Walle
* Vivek Goyal <[EMAIL PROTECTED]> [2007-09-12 13:23]: > On Tue, Sep 11, 2007 at 12:01:10PM +0200, Bernhard Walle wrote: > > * Vivek Goyal <[EMAIL PROTECTED]> [2007-09-11 08:15]: > > > > > > "offset" seems to be optional in the new syntax. What happens if user does > > > not specify offset. I think

Re: [patch 1/5] Extended crashkernel command line

2007-09-12 Thread Vivek Goyal
On Tue, Sep 11, 2007 at 12:01:10PM +0200, Bernhard Walle wrote: > * Vivek Goyal <[EMAIL PROTECTED]> [2007-09-11 08:15]: > > > > "offset" seems to be optional in the new syntax. What happens if user does > > not specify offset. I think crash_base will be set to zero and system will > > try to reser

Re: [patch 1/5] Extended crashkernel command line

2007-09-11 Thread Bernhard Walle
* Lombard, David N <[EMAIL PROTECTED]> [2007-09-11 17:32]: > > lilo: > append= > > Appends the options specified to the parameter line passed to > the kernel. Given that lilo appends the user-specified command line, I think it's the best to honor the last value. It has also been the p

Re: [patch 1/5] Extended crashkernel command line

2007-09-11 Thread Lombard, David N
On Tue, Sep 11, 2007 at 03:14:45PM +0200, Olaf Dabrunz wrote: > On 09-Sep-07, Bernhard Walle wrote: > > If there are multiple occurrences, then the last one is taken. The > > advantage > > is that if you have a bootloader like lilo or elilo which allows you to > > append > > a command line param

Re: [patch 1/5] Extended crashkernel command line

2007-09-11 Thread Olaf Dabrunz
On 09-Sep-07, Bernhard Walle wrote: > If there are multiple occurrences, then the last one is taken. The advantage > is that if you have a bootloader like lilo or elilo which allows you to append > a command line parameter but not to remove one (like in GRUB), then you can > add > another crashke

Re: [patch 1/5] Extended crashkernel command line

2007-09-11 Thread Bernhard Walle
* Vivek Goyal <[EMAIL PROTECTED]> [2007-09-11 08:15]: > > "offset" seems to be optional in the new syntax. What happens if user does > not specify offset. I think crash_base will be set to zero and system will > try to reserve x amount of memory start at zero? That would fail? That's handled in t

Re: [patch 1/5] Extended crashkernel command line

2007-09-10 Thread Vivek Goyal
On Sun, Sep 09, 2007 at 10:39:15AM +0200, Bernhard Walle wrote: [..] > + > +/* > + * parsing the "crashkernel" commandline > + * > + * this code is intended to be called from architecture specific code > + */ > + > + > +/* > + * This function parses command lines in the format > + * > + * crashk

[patch 1/5] Extended crashkernel command line

2007-09-09 Thread Bernhard Walle
This is the generic part of the patch. It adds a parse_crashkernel() function in kernel/kexec.c that is called by the architecture specific code that actually reserves the memory. That function takes the whole command line and looks itself for "crashkernel=" in it. If there are multiple occurrence