Re: [patch 1/3] mm: pagecache write deadlocks zerolength fix

2006-11-30 Thread Nick Piggin
On Thu, Nov 30, 2006 at 11:30:33AM +0100, Andreas Schwab wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > > On Thu, Nov 30, 2006 at 11:15:39AM +0100, Andreas Schwab wrote: > >> Nick Piggin <[EMAIL PROTECTED]> writes: > >> > >> > writev with a zero-length segment is a noop, and we shouldn't re

Re: [patch 1/3] mm: pagecache write deadlocks zerolength fix

2006-11-30 Thread Andreas Schwab
Nick Piggin <[EMAIL PROTECTED]> writes: > On Thu, Nov 30, 2006 at 11:15:39AM +0100, Andreas Schwab wrote: >> Nick Piggin <[EMAIL PROTECTED]> writes: >> >> > writev with a zero-length segment is a noop, and we shouldn't return >> > EFAULT. >> >> AFAICS the callers of these functions never pass a

Re: [patch 1/3] mm: pagecache write deadlocks zerolength fix

2006-11-30 Thread Nick Piggin
On Thu, Nov 30, 2006 at 11:15:39AM +0100, Andreas Schwab wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > > writev with a zero-length segment is a noop, and we shouldn't return EFAULT. > > AFAICS the callers of these functions never pass a zero length. They can in the case of a zero length w

Re: [patch 1/3] mm: pagecache write deadlocks zerolength fix

2006-11-30 Thread Andreas Schwab
Nick Piggin <[EMAIL PROTECTED]> writes: > writev with a zero-length segment is a noop, and we shouldn't return EFAULT. AFAICS the callers of these functions never pass a zero length. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnb

[patch 1/3] mm: pagecache write deadlocks zerolength fix

2006-11-29 Thread Nick Piggin
writev with a zero-length segment is a noop, and we shouldn't return EFAULT. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> Index: linux-2.6/include/linux/pagemap.h === --- linux-2.6.orig/include/linux/pagemap.h +++ linux-2.6/includ