Re: [linux-kernel] Re: [patch 1/2] x86: define outb_pic and inb_pic to stop using outb_p and inb_p

2008-02-18 Thread David P. Reed
Alan Cox wrote: +unsigned char inb_pic(unsigned int port) +{ + /* delay for some accesses to PIC on motherboard or in chipset must be + at least one microsecond, but be safe here. */ + unsigned char value = inb(port); + udelay(2); + return value; +} inline

Re: [patch 1/2] x86: define outb_pic and inb_pic to stop using outb_p and inb_p

2008-02-18 Thread Alan Cox
> +unsigned char inb_pic(unsigned int port) > +{ > + /* delay for some accesses to PIC on motherboard or in chipset must be > +at least one microsecond, but be safe here. */ > + unsigned char value = inb(port); > + udelay(2); > + return value; > +} inline it. Its almost no

[patch 1/2] x86: define outb_pic and inb_pic to stop using outb_p and inb_p

2008-02-18 Thread David P. Reed
The delay between io port accesses to the PIC is now defined using outb_pic and inb_pic. This fix provides the next step, using udelay(2) to define the *PIC specific* timing requirements, rather than on bus-oriented timing, which is not well calibrated. Again, the primary reason for fixing this i