Re: [patch 1/2] block, drbd: fix drbd_req_new() initialization

2015-03-13 Thread David Rientjes
On Sat, 7 Mar 2015, David Rientjes wrote: > > >>> mempool_alloc() does not support __GFP_ZERO since elements may come from > > >>> memory that has already been released by mempool_free(). > > >>> > > >>> Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly > > >>> initialize it to

Re: [DRBD-user] [patch 1/2] block, drbd: fix drbd_req_new() initialization

2015-03-10 Thread David Rientjes
On Tue, 10 Mar 2015, Lars Ellenberg wrote: > > mempool_alloc() does not support __GFP_ZERO since elements may come from > > memory that has already been released by mempool_free(). > > > > Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly > > initialize it to 0. > > We used t

Re: [DRBD-user] [patch 1/2] block, drbd: fix drbd_req_new() initialization

2015-03-10 Thread Lars Ellenberg
On Sat, Mar 07, 2015 at 04:24:02PM -0800, David Rientjes wrote: > mempool_alloc() does not support __GFP_ZERO since elements may come from > memory that has already been released by mempool_free(). > > Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly > initialize it to 0. We

Re: [patch 1/2] block, drbd: fix drbd_req_new() initialization

2015-03-07 Thread Jens Axboe
On 03/07/2015 06:27 PM, David Rientjes wrote: > On Sat, 7 Mar 2015, Jens Axboe wrote: > > mempool_alloc() does not support __GFP_ZERO since elements may come from > memory that has already been released by mempool_free(). > > Remove __GFP_ZERO from mempool_alloc() in drbd_req_new()

Re: [patch 1/2] block, drbd: fix drbd_req_new() initialization

2015-03-07 Thread David Rientjes
On Sat, 7 Mar 2015, Jens Axboe wrote: > >>> mempool_alloc() does not support __GFP_ZERO since elements may come from > >>> memory that has already been released by mempool_free(). > >>> > >>> Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly > >>> initialize it to 0. > >> > >>

Re: [patch 1/2] block, drbd: fix drbd_req_new() initialization

2015-03-07 Thread Jens Axboe
On 03/07/2015 05:53 PM, David Rientjes wrote: > On Sat, 7 Mar 2015, Jens Axboe wrote: > >>> mempool_alloc() does not support __GFP_ZERO since elements may come from >>> memory that has already been released by mempool_free(). >>> >>> Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and pro

Re: [patch 1/2] block, drbd: fix drbd_req_new() initialization

2015-03-07 Thread David Rientjes
On Sat, 7 Mar 2015, Jens Axboe wrote: > > mempool_alloc() does not support __GFP_ZERO since elements may come from > > memory that has already been released by mempool_free(). > > > > Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly > > initialize it to 0. > > You should add

Re: [patch 1/2] block, drbd: fix drbd_req_new() initialization

2015-03-07 Thread Jens Axboe
On 03/07/2015 05:24 PM, David Rientjes wrote: mempool_alloc() does not support __GFP_ZERO since elements may come from memory that has already been released by mempool_free(). Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly initialize it to 0. You should add it to mempool

[patch 1/2] block, drbd: fix drbd_req_new() initialization

2015-03-07 Thread David Rientjes
mempool_alloc() does not support __GFP_ZERO since elements may come from memory that has already been released by mempool_free(). Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly initialize it to 0. Cc: Lars Ellenberg Cc: Jens Axboe Signed-off-by: David Rientjes --- drive