Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Pavel Machek
Hi! > > > So, if the collie folk would like to clean their changes up and send > > > them to me as the driver author, I'll see about integrating them into > > > my version and we'll take it from there. > > > > Okay, will do. [Is there chance to pull your tree using git? It would > > help a bit...

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Russell King
On Tue, Jul 26, 2005 at 12:06:59AM +0200, Pavel Machek wrote: > > > Also it looks to me like mcp.h should go into asm/arch-sa1100, so > > > that other drivers can use it... > > > > That doesn't make sense when you have other non-SA1100 devices using > > mcp-core.c. Whether that happens or not I'v

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Pavel Machek
Hi! > > > The problem is that the parent doesn't actually know how many > > > devices to create nor what to call them, and they're logically > > > indistinguishable from each other so there's no logical naming > > > system. > > > > Then we should probably not try to force them into driver model.

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Pavel Machek
Hi! > > > > This adds support for reading ADCs (etc), neccessary to operate touch > > > > screen on Sharp Zaurus sl-5500. > > > > > > I would like to know what the diffs are between my version (attached) > > > and this version before they get applied. > > > > Hmm, diff looks quite big (attached)

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Pavel Machek
Hi! > > Can we change this to "while (!kthread_should_stop())" to make me > > completely happy? > > I still ask, and I'll keep repeating this. What is the difference > between this and the reference implementation which is known to > work on other hardware. I think I posted diffs already, but t

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Pavel Machek
Hi! > > I have made quite a lot of cleanups to touchscreen part, and it seems > > to be acceptable by input people. I think it should go into > > drivers/input/touchscreen/collie_ts.c... Also it looks to me like > > mcp.h should go into asm/arch-sa1100, so that other drivers can use it... > > I h

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Russell King
On Mon, Jul 25, 2005 at 11:47:25AM -0500, Dmitry Torokhov wrote: > On 7/25/05, Russell King <[EMAIL PROTECTED]> wrote: > > If you look at _my_ version, you'll notice that it doesn't use the > > class interface stuff. A previous version of it did, and this seems > > to be what the collie stuff is b

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Dmitry Torokhov
On 7/25/05, Russell King <[EMAIL PROTECTED]> wrote: > On Mon, Jul 25, 2005 at 11:02:43AM -0500, Dmitry Torokhov wrote: > > On 7/25/05, Russell King <[EMAIL PROTECTED]> wrote: > > > On Mon, Jul 25, 2005 at 10:16:05AM -0500, Dmitry Torokhov wrote: > > > > If the problem is that you have a single piec

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Russell King
On Mon, Jul 25, 2005 at 11:02:43AM -0500, Dmitry Torokhov wrote: > On 7/25/05, Russell King <[EMAIL PROTECTED]> wrote: > > On Mon, Jul 25, 2005 at 10:16:05AM -0500, Dmitry Torokhov wrote: > > > If the problem is that you have a single piece of hardware you need to > > > bind several drivers to - I

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Russell King
On Mon, Jul 25, 2005 at 06:56:07AM +0200, Pavel Machek wrote: > Hi! > > > > This adds support for reading ADCs (etc), neccessary to operate touch > > > screen on Sharp Zaurus sl-5500. > > > > I would like to know what the diffs are between my version (attached) > > and this version before they ge

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Dmitry Torokhov
On 7/25/05, Russell King <[EMAIL PROTECTED]> wrote: > On Mon, Jul 25, 2005 at 10:16:05AM -0500, Dmitry Torokhov wrote: > > If the problem is that you have a single piece of hardware you need to > > bind several drivers to - I guess you will have to create a new > > sub-device bus for that. Or just

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Russell King
On Mon, Jul 25, 2005 at 10:16:05AM -0500, Dmitry Torokhov wrote: > If the problem is that you have a single piece of hardware you need to > bind several drivers to - I guess you will have to create a new > sub-device bus for that. Or just register sub-devices on the same bus > the parent device is

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Dmitry Torokhov
Hi Pavel, On 7/24/05, Pavel Machek <[EMAIL PROTECTED]> wrote: > > I have made quite a lot of cleanups to touchscreen part, and it seems > to be acceptable by input people. I think it should go into > drivers/input/touchscreen/collie_ts.c... Also it looks to me like > mcp.h should go into asm/arch

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-25 Thread Pavel Machek
Hi! > > This adds support for reading ADCs (etc), neccessary to operate touch > > screen on Sharp Zaurus sl-5500. > > I would like to know what the diffs are between my version (attached) > and this version before they get applied. Hmm, diff looks quite big (attached), and I got it from lenz for

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-24 Thread randy_dunlap
On Sun, 24 Jul 2005 17:47:56 +0100 Russell King wrote: > On Fri, Jul 22, 2005 at 08:01:09PM +0200, Pavel Machek wrote: > > This adds support for reading ADCs (etc), neccessary to operate touch > > screen on Sharp Zaurus sl-5500. > > I would like to know what the diffs are between my version (atta

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-24 Thread Richard Purdie
On Sun, 2005-07-24 at 17:47 +0100, Russell King wrote: > On Fri, Jul 22, 2005 at 08:01:09PM +0200, Pavel Machek wrote: > > This adds support for reading ADCs (etc), neccessary to operate touch > > screen on Sharp Zaurus sl-5500. > > I would like to know what the diffs are between my version (attac

Re: [patch 1/2] Touchscreen support for sharp sl-5500

2005-07-24 Thread Russell King
On Fri, Jul 22, 2005 at 08:01:09PM +0200, Pavel Machek wrote: > This adds support for reading ADCs (etc), neccessary to operate touch > screen on Sharp Zaurus sl-5500. I would like to know what the diffs are between my version (attached) and this version before they get applied. The only reason m

[patch 1/2] Touchscreen support for sharp sl-5500

2005-07-22 Thread Pavel Machek
This adds support for reading ADCs (etc), neccessary to operate touch screen on Sharp Zaurus sl-5500. Please apply, Pavel Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig ---