Re: [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying

2015-03-26 Thread Johannes Weiner
On Thu, Mar 26, 2015 at 04:58:46PM +0100, Michal Hocko wrote: > On Wed 25-03-15 02:17:12, Johannes Weiner wrote: > > There is not much point in rushing back to the freelists and burning > > CPU cycles in direct reclaim when somebody else is in the process of > > OOM killing, or right after issuing

Re: [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying

2015-03-26 Thread Johannes Weiner
On Thu, Mar 26, 2015 at 04:38:47PM +0100, Michal Hocko wrote: > On Thu 26-03-15 11:23:43, Johannes Weiner wrote: > > On Thu, Mar 26, 2015 at 03:32:23PM +0100, Michal Hocko wrote: > > > On Thu 26-03-15 07:24:45, Johannes Weiner wrote: > > > > On Wed, Mar 25, 2015 at 11:15:48PM +0900, Tetsuo Handa wr

Re: [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying

2015-03-26 Thread Michal Hocko
On Wed 25-03-15 02:17:12, Johannes Weiner wrote: > There is not much point in rushing back to the freelists and burning > CPU cycles in direct reclaim when somebody else is in the process of > OOM killing, or right after issuing a kill ourselves, because it could > take some time for the OOM victim

Re: [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying

2015-03-26 Thread Michal Hocko
On Thu 26-03-15 11:23:43, Johannes Weiner wrote: > On Thu, Mar 26, 2015 at 03:32:23PM +0100, Michal Hocko wrote: > > On Thu 26-03-15 07:24:45, Johannes Weiner wrote: > > > On Wed, Mar 25, 2015 at 11:15:48PM +0900, Tetsuo Handa wrote: > > > > Johannes Weiner wrote: > > [...] > > > > > /* > > >

Re: [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying

2015-03-26 Thread Johannes Weiner
On Thu, Mar 26, 2015 at 03:32:23PM +0100, Michal Hocko wrote: > On Thu 26-03-15 07:24:45, Johannes Weiner wrote: > > On Wed, Mar 25, 2015 at 11:15:48PM +0900, Tetsuo Handa wrote: > > > Johannes Weiner wrote: > [...] > > > > /* > > > > -* Acquire the oom lock. If that fails, somebod

Re: [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying

2015-03-26 Thread Michal Hocko
On Thu 26-03-15 07:24:45, Johannes Weiner wrote: > On Wed, Mar 25, 2015 at 11:15:48PM +0900, Tetsuo Handa wrote: > > Johannes Weiner wrote: [...] > > > /* > > > - * Acquire the oom lock. If that fails, somebody else is > > > - * making progress for us. > > > + * This allocating task can becom

Re: [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying

2015-03-26 Thread Johannes Weiner
On Wed, Mar 25, 2015 at 06:01:48PM +0100, Vlastimil Babka wrote: > On 03/25/2015 03:15 PM, Tetsuo Handa wrote: > >Johannes Weiner wrote: > >>diff --git a/mm/oom_kill.c b/mm/oom_kill.c > >>index 5cfda39b3268..e066ac7353a4 100644 > >>--- a/mm/oom_kill.c > >>+++ b/mm/oom_kill.c > >>@@ -711,12 +711,15

Re: [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying

2015-03-26 Thread Johannes Weiner
On Wed, Mar 25, 2015 at 11:15:48PM +0900, Tetsuo Handa wrote: > Johannes Weiner wrote: > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > > index 5cfda39b3268..e066ac7353a4 100644 > > --- a/mm/oom_kill.c > > +++ b/mm/oom_kill.c > > @@ -711,12 +711,15 @@ bool out_of_memory(struct zonelist *zonelist, g

Re: [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying

2015-03-25 Thread Vlastimil Babka
On 03/25/2015 03:15 PM, Tetsuo Handa wrote: Johannes Weiner wrote: diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 5cfda39b3268..e066ac7353a4 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -711,12 +711,15 @@ bool out_of_memory(struct zonelist *zonelist, gfp_t gfp_mask, kille

Re: [patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying

2015-03-25 Thread Tetsuo Handa
Johannes Weiner wrote: > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 5cfda39b3268..e066ac7353a4 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -711,12 +711,15 @@ bool out_of_memory(struct zonelist *zonelist, gfp_t > gfp_mask, > killed = 1; > } > out: > + if

[patch 08/12] mm: page_alloc: wait for OOM killer progress before retrying

2015-03-24 Thread Johannes Weiner
There is not much point in rushing back to the freelists and burning CPU cycles in direct reclaim when somebody else is in the process of OOM killing, or right after issuing a kill ourselves, because it could take some time for the OOM victim to release memory. This is a very cold error path, so t