Re: [patch 08/12] can: c_can: Makethe code readable

On Tue, 18 Mar 2014, Joe Perches wrote: > On Tue, 2014-03-18 at 17:19 +, Thomas Gleixner wrote: > > [patch] > > Hi > > The multi-while loop > > while ((obj = ffs(pend)) && quota > 0) { > ... > } while ((obj = ffs(pend)) && quota > 0); > > looks, umm, unusual.

Re: [patch 08/12] can: c_can: Makethe code readable

On Tue, 2014-03-18 at 17:19 +, Thomas Gleixner wrote: [patch] Hi The multi-while loop while ((obj = ffs(pend)) && quota > 0) { ... } while ((obj = ffs(pend)) && quota > 0); looks, umm, unusual. -- To unsubscribe from this list: send the line "unsubscribe l

[patch 08/12] can: c_can: Makethe code readable

If every other line contains line breaks, that's a clear sign for indentation level madness. Split out the inner loop and move the code to a separate function. gcc creates slightly worse code for that, but we'll fix that in the next step. Signed-off-by: Thomas Gleixner --- drivers/net/can/c_can/