Re: [patch 08/12] MIPS/alchemy: Remove pointless irqdisable/enable

2015-07-14 Thread Thomas Gleixner
On Tue, 14 Jul 2015, Ralf Baechle wrote: > On Tue, Jul 14, 2015 at 10:55:08AM +0200, Manuel Lauss wrote: > > Yes. Add #include on top and it works again. > > This hardware is problematic, an older variant with identical verilog > > code in the cpld's > > irq unit works fine without this. > > So

Re: [patch 08/12] MIPS/alchemy: Remove pointless irqdisable/enable

2015-07-14 Thread Ralf Baechle
On Tue, Jul 14, 2015 at 10:55:08AM +0200, Manuel Lauss wrote: > On Tue, Jul 14, 2015 at 10:16 AM, Thomas Gleixner wrote: > > On Tue, 14 Jul 2015, Manuel Lauss wrote: > > > >> On Mon, Jul 13, 2015 at 10:46 PM, Thomas Gleixner > >> wrote: > >> > bcsr_csc_handler() is a cascading interrupt handler

Re: [patch 08/12] MIPS/alchemy: Remove pointless irqdisable/enable

2015-07-14 Thread Manuel Lauss
On Tue, Jul 14, 2015 at 10:16 AM, Thomas Gleixner wrote: > On Tue, 14 Jul 2015, Manuel Lauss wrote: > >> On Mon, Jul 13, 2015 at 10:46 PM, Thomas Gleixner wrote: >> > bcsr_csc_handler() is a cascading interrupt handler. It has a >> > disable_irq_nosync()/enable_irq() pair around the generic_handl

Re: [patch 08/12] MIPS/alchemy: Remove pointless irqdisable/enable

2015-07-14 Thread Thomas Gleixner
On Tue, 14 Jul 2015, Manuel Lauss wrote: > On Mon, Jul 13, 2015 at 10:46 PM, Thomas Gleixner wrote: > > bcsr_csc_handler() is a cascading interrupt handler. It has a > > disable_irq_nosync()/enable_irq() pair around the generic_handle_irq() > > call. The value of this disable/enable is zero becau

Re: [patch 08/12] MIPS/alchemy: Remove pointless irqdisable/enable

2015-07-13 Thread Manuel Lauss
On Mon, Jul 13, 2015 at 10:46 PM, Thomas Gleixner wrote: > bcsr_csc_handler() is a cascading interrupt handler. It has a > disable_irq_nosync()/enable_irq() pair around the generic_handle_irq() > call. The value of this disable/enable is zero because its a complete > noop: > > disable_irq_nosync()

[patch 08/12] MIPS/alchemy: Remove pointless irqdisable/enable

2015-07-13 Thread Thomas Gleixner
bcsr_csc_handler() is a cascading interrupt handler. It has a disable_irq_nosync()/enable_irq() pair around the generic_handle_irq() call. The value of this disable/enable is zero because its a complete noop: disable_irq_nosync() merily increments the disable count without actually masking the int