Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

2007-03-17 Thread Rusty Russell
On Fri, 2007-03-16 at 11:39 -0700, Jeremy Fitzhardinge wrote: > Ingo Molnar wrote: > >> + /* Make sure kernel address space is empty so that a pagetable > >> + will be allocated for it. */ > >> > > > > comment style. > > > > As you've noticed its a comment style I use quite often. Me

Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

2007-03-16 Thread Steven Rostedt
On Fri, 2007-03-16 at 11:39 -0700, Jeremy Fitzhardinge wrote: > Ingo Molnar wrote: > >> + /* Make sure kernel address space is empty so that a pagetable > >> + will be allocated for it. */ > >> > > > > comment style. > > > > As you've noticed its a comment style I use quite often. I

Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

2007-03-16 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: >> +/* Make sure kernel address space is empty so that a pagetable >> + will be allocated for it. */ >> > > comment style. > As you've noticed its a comment style I use quite often. I use it for what's essentially a little local comment, rather than a block co

Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

2007-03-16 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > This patch introduces paravirt_ops hooks to control how the kernel's > initial pagetable is set up. looks good. Some minor nits: > + /* Make sure kernel address space is empty so that a pagetable > +will be allocated for it. */ com

[patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

2007-03-01 Thread Jeremy Fitzhardinge
This patch introduces paravirt_ops hooks to control how the kernel's initial pagetable is set up. In the case of a native boot, the very early bootstrap code creates a simple non-PAE pagetable to map the kernel and physical memory. When the VM subsystem is initialized, it creates a proper pagetab

Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

2007-02-27 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > >> === >> --- a/include/asm-i386/pgtable.h >> +++ b/include/asm-i386/pgtable.h >> @@ -15,7 +15,10 @@ >> #include >> #include >> #include >> + >> +#ifdef

Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

2007-02-27 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > === > --- a/include/asm-i386/pgtable.h > +++ b/include/asm-i386/pgtable.h > @@ -15,7 +15,10 @@ > #include > #include > #include > + > +#ifdef CONFIG_PARAVIRT /* g

[patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

2007-02-27 Thread Jeremy Fitzhardinge
This patch introduces paravirt_ops hooks to control how the kernel's initial pagetable is set up. In the case of a native boot, the very early bootstrap code creates a simple non-PAE pagetable to map the kernel and physical memory. When the VM subsystem is initialized, it creates a proper pagetab