Re: [patch 05/10] Text Edit Lock - Alternative code for i386 and x86_64

2007-09-11 Thread Mathieu Desnoyers
* Andi Kleen ([EMAIL PROTECTED]) wrote: > On Fri, Sep 07, 2007 at 10:04:42AM -0400, Mathieu Desnoyers wrote: > > * Andi Kleen ([EMAIL PROTECTED]) wrote: > > > On Thu, Sep 06, 2007 at 04:01:29PM -0400, Mathieu Desnoyers wrote: > > > > + sync_core(); > > > > + /* Not strictly needed, but

Re: [patch 05/10] Text Edit Lock - Alternative code for i386 and x86_64

2007-09-07 Thread Andi Kleen
On Fri, Sep 07, 2007 at 10:04:42AM -0400, Mathieu Desnoyers wrote: > * Andi Kleen ([EMAIL PROTECTED]) wrote: > > On Thu, Sep 06, 2007 at 04:01:29PM -0400, Mathieu Desnoyers wrote: > > > + sync_core(); > > > + /* Not strictly needed, but can speed CPU recovery up. */ > > > > That turned out to brea

Re: [patch 05/10] Text Edit Lock - Alternative code for i386 and x86_64

2007-09-07 Thread Mathieu Desnoyers
* Ananth N Mavinakayanahalli ([EMAIL PROTECTED]) wrote: > On Thu, Sep 06, 2007 at 04:01:29PM -0400, Mathieu Desnoyers wrote: > > > > > Index: linux-2.6-lttng/arch/i386/kernel/alternative.c > > === > > --- linux-2.6-lttng.orig/arch/i

Re: [patch 05/10] Text Edit Lock - Alternative code for i386 and x86_64

2007-09-07 Thread Mathieu Desnoyers
* Andi Kleen ([EMAIL PROTECTED]) wrote: > On Thu, Sep 06, 2007 at 04:01:29PM -0400, Mathieu Desnoyers wrote: > > + sync_core(); > > + /* Not strictly needed, but can speed CPU recovery up. */ > > That turned out to break on some VIA CPUs. Should be removed. > Hrm, when does it break ? At boo

Re: [patch 05/10] Text Edit Lock - Alternative code for i386 and x86_64

2007-09-07 Thread Ananth N Mavinakayanahalli
On Thu, Sep 06, 2007 at 04:01:29PM -0400, Mathieu Desnoyers wrote: > Index: linux-2.6-lttng/arch/i386/kernel/alternative.c > === > --- linux-2.6-lttng.orig/arch/i386/kernel/alternative.c 2007-09-06 > 14:32:11.0 -0400

Re: [patch 05/10] Text Edit Lock - Alternative code for i386 and x86_64

2007-09-07 Thread Andi Kleen
On Thu, Sep 06, 2007 at 04:01:29PM -0400, Mathieu Desnoyers wrote: > + sync_core(); > + /* Not strictly needed, but can speed CPU recovery up. */ That turned out to break on some VIA CPUs. Should be removed. > + if (cpu_has_clflush) > + for (faddr = addr; faddr < addr + le

[patch 05/10] Text Edit Lock - Alternative code for i386 and x86_64

2007-09-06 Thread Mathieu Desnoyers
Fix a memcpy that should be a text_poke (in apply_alternatives). Use kernel_wp_save/kernel_wp_restore in text_poke to support DEBUG_RODATA correctly and so the CPU HOTPLUG special case can be removed. clflush all the cachelines touched by text_poke. Add text_set(), which is basically a memset-li

[patch 05/10] Text Edit Lock - Alternative code for i386 and x86_64

2007-08-27 Thread Mathieu Desnoyers
Fix a memcpy that should be a text_poke (in apply_alternatives). Use kernel_wp_save/kernel_wp_restore in text_poke to support DEBUG_RODATA correctly and so the CPU HOTPLUG special case can be removed. clflush all the cachelines touched by text_poke. Add text_set(), which is basically a memset-li