Re: [patch 00/22] pollfs: filesystem abstraction for pollable objects

2007-05-02 Thread Davi Arnaut
Davide Libenzi wrote: On Wed, 2 May 2007, Davi Arnaut wrote: So in this case I may borrow some signalfd code :-) I really like the signalfd approach, but IMHO the code is quite ugly and duplicates a lot of hairy code. Ugly, really? Please ... + while (!mutex_trylock(&evs->mutex

Re: [patch 00/22] pollfs: filesystem abstraction for pollable objects

2007-05-02 Thread Davide Libenzi
On Wed, 2 May 2007, Davi Arnaut wrote: > So in this case I may borrow some signalfd code :-) I really like the > signalfd approach, but IMHO the code is quite ugly and duplicates > a lot of hairy code. Ugly, really? Please ... + while (!mutex_trylock(&evs->mutex)) + cpu_relax

Re: [patch 00/22] pollfs: filesystem abstraction for pollable objects

2007-05-02 Thread Davi Arnaut
Davide Libenzi wrote: On Wed, 2 May 2007, Davi Arnaut wrote: Davide Libenzi wrote: On Tue, 1 May 2007, Andrew Morton wrote: David, could you provide some feedback please? The patches are stunningly free of comments, but you used to do that to me pretty often so my sympathy

Re: [patch 00/22] pollfs: filesystem abstraction for pollable objects

2007-05-02 Thread Davide Libenzi
On Wed, 2 May 2007, Davi Arnaut wrote: > Davide Libenzi wrote: > > On Tue, 1 May 2007, Andrew Morton wrote: > > > > > > > David, could you provide some feedback please? The patches are stunningly > > > free of comments, but you used to do that to me pretty often so my > > > sympathy > > > is

Re: [patch 00/22] pollfs: filesystem abstraction for pollable objects

2007-05-02 Thread Davi Arnaut
Davide Libenzi wrote: On Tue, 1 May 2007, Andrew Morton wrote: David, could you provide some feedback please? The patches are stunningly free of comments, but you used to do that to me pretty often so my sympathy is limited ;) You bastard! :) Ok, from a brief look ... [general] The

Re: [patch 00/22] pollfs: filesystem abstraction for pollable objects

2007-05-02 Thread Davide Libenzi
On Tue, 1 May 2007, Andrew Morton wrote: > David, could you provide some feedback please? The patches are stunningly > free of comments, but you used to do that to me pretty often so my sympathy > is limited ;) You bastard! :) Ok, from a brief look ... [general] The code adds an extra indirecti

Re: [patch 00/22] pollfs: filesystem abstraction for pollable objects

2007-05-01 Thread Andrew Morton
On Wed, 02 May 2007 02:22:35 -0300 Davi Arnaut <[EMAIL PROTECTED]> wrote: > This patch set introduces a new file system for the delivery of pollable > events through file descriptors. To the detriment of debugability, pollable > objects are a nice adjunct to nonblocking/epoll/event-based servers.

[patch 00/22] pollfs: filesystem abstraction for pollable objects

2007-05-01 Thread Davi Arnaut
This patch set introduces a new file system for the delivery of pollable events through file descriptors. To the detriment of debugability, pollable objects are a nice adjunct to nonblocking/epoll/event-based servers. The pollfs filesystem abstraction provides better mechanisms needed for creating