Re: [patch -mm 1/1] remove useless tolower in isofs

2007-05-29 Thread young dave
Hi, Your email client replaces tabs with spaces. The tabs replacing was caused by copying them from vi session in gnome-terminal. I find the proper way is to copy them from some gui editor. Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [patch -mm 1/1] remove useless tolower in isofs

2007-05-29 Thread young dave
Hi, Thank you, andrew. Your email client replaces tabs with spaces. Really? I use gmail web via firefox, next time I will use mutt to send patches. Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majord

Re: [patch -mm 1/1] remove useless tolower in isofs

2007-05-29 Thread Andrew Morton
On Mon, 28 May 2007 03:11:04 + "young dave" <[EMAIL PROTECTED]> wrote: > Hi, > > And then there's the supercompact form. > > > > while (len--) { > > hash = partial_name_hash(tolower(*name++), hash); > > } > > > > But I do not like the last one at all. The first one is the best, because

Re: [patch -mm 1/1] remove useless tolower in isofs

2007-05-28 Thread Pekka Enberg
On 5/28/07, young dave <[EMAIL PROTECTED]> wrote: Thanks, can this small fix be merged? Yes. Please be patient and wait for Andrew to pick it up. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [patch -mm 1/1] remove useless tolower in isofs

2007-05-28 Thread young dave
Hi, Thanks, can this small fix be merged? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch -mm 1/1] remove useless tolower in isofs

2007-05-27 Thread Pekka Enberg
On 5/28/07, young dave <[EMAIL PROTECTED]> wrote: Remove useless tolower in isofs [snip] c = tolower(*name++); - hash = partial_name_hash(tolower(c), hash); + hash = partial_name_hash(c, hash); Looks good to me. Acked-by: Pekka Enberg <[EMAIL PRO

Re: [patch -mm 1/1] remove useless tolower in isofs

2007-05-27 Thread young dave
Hi, And then there's the supercompact form. while (len--) { hash = partial_name_hash(tolower(*name++), hash); } But I do not like the last one at all. The first one is the best, because it clearly separates the condition and iteration parts of the expression, while STILL being only thre

Re: [patch -mm 1/1] remove useless tolower in isofs

2007-05-27 Thread John Anthony Kazos Jr.
> Hi, > Remove useless tolower in isofs > > Signed-off-by: dave young <[EMAIL PROTECTED]> > > inode.c |2 +- > 1 file changed, 1 insertions(+), 1 deletions(-) > > diff -dur linux/fs/isofs/inode.c linux.new/fs/isofs/inode.c > --- linux/fs/isofs/inode.c 2007-05-28 08:54:33.0 +

[patch -mm 1/1] remove useless tolower in isofs

2007-05-27 Thread young dave
Hi, Remove useless tolower in isofs Signed-off-by: dave young <[EMAIL PROTECTED]> inode.c |2 +- 1 file changed, 1 insertions(+), 1 deletions(-) diff -dur linux/fs/isofs/inode.c linux.new/fs/isofs/inode.c --- linux/fs/isofs/inode.c 2007-05-28 08:54:33.0 + +++ linux.new/fs/is