Re: [patch -mm] slab: use CPU_LOCK_[ACQUIRE|RELEASE]

2007-01-10 Thread Srivatsa Vaddagiri
On Wed, Jan 10, 2007 at 10:20:28AM -0800, Christoph Lameter wrote: > I have got a bad feeling about upcoming deadlock problems when looking at > the mutex_lock / unlock code in cpuup_callback in slab.c. Branches > that just obtain a lock or release a lock? I hope there is some > control of what ha

Re: [patch -mm] slab: use CPU_LOCK_[ACQUIRE|RELEASE]

2007-01-10 Thread Christoph Lameter
On Tue, 9 Jan 2007, Heiko Carstens wrote: > - case CPU_UP_PREPARE: > + case CPU_LOCK_ACQUIRE: > mutex_lock(&cache_chain_mutex); > + break; I have got a bad feeling about upcoming deadlock problems when looking at the mutex_lock / unlock code in cpuup_callback in

[patch -mm] slab: use CPU_LOCK_[ACQUIRE|RELEASE]

2007-01-09 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Looks like this was forgotten when CPU_LOCK_[ACQUIRE|RELEASE] was introduced. Cc: Pekka Enberg <[EMAIL PROTECTED]> Cc: Srivatsa Vaddagiri <[EMAIL PROTECTED]> Cc: Gautham Shenoy <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- mm/s