On Thu, 28 Jun 2007, Alan Cox wrote:
> > check_signature() needs readb() but with some setups (s390, m68k
> > allmodconfig)
> > there is no implementation of readb. This causes build errors with
> > -Werror-implicit-function-declaration.
>
> This completely bogus. readb() should be present on M6
Hi,
On Fri, 29 Jun 2007, Alan Cox wrote:
> > > check_signature is relevant for anything with MMIO space (for example you
> > > can legitimately want to check_signature a MAC68K Nubus ROM).
> >
> > A generic check_signature() is a little difficult if we have separate io
> > functions for every b
> > check_signature is relevant for anything with MMIO space (for example you
> > can legitimately want to check_signature a MAC68K Nubus ROM).
>
> A generic check_signature() is a little difficult if we have separate io
> functions for every bus.
Does M68K implement iomap() and pci_iomap and fr
On Thu, 28 Jun 2007 18:45:11 -0400
Jeff Dike <[EMAIL PROTECTED]> wrote:
> On Thu, Jun 28, 2007 at 11:25:37PM +0100, Alan Cox wrote:
> > This completely bogus. readb() should be present on M68K, fix the
> > platform to implement readb() for MMIO, even if your MMIO readb is a
> > moveb instruction.
Hi,
On Thu, 28 Jun 2007, Alan Cox wrote:
> > check_signature() needs readb() but with some setups (s390, m68k
> > allmodconfig)
> > there is no implementation of readb. This causes build errors with
> > -Werror-implicit-function-declaration.
>
> This completely bogus. readb() should be present
On Thu, Jun 28, 2007 at 11:25:37PM +0100, Alan Cox wrote:
> This completely bogus. readb() should be present on M68K, fix the
> platform to implement readb() for MMIO, even if your MMIO readb is a
> moveb instruction.
>
> check_signature is relevant for anything with MMIO space (for example you
>
> check_signature() needs readb() but with some setups (s390, m68k allmodconfig)
> there is no implementation of readb. This causes build errors with
> -Werror-implicit-function-declaration.
This completely bogus. readb() should be present on M68K, fix the
platform to implement readb() for MMIO,
On Thu, 28 Jun 2007 20:47:33 +0200 (CEST)
Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> > > Apart from many Kconfig dependencies on HAS_IOMEM, CONFIG_HAS_IOMEM is
> > > further only used to control the build of lib/iomap_copy.c, which
> > > doesn't use readb() and friends, but the __raw*() opera
On Thu, 28 Jun 2007, Andrew Morton wrote:
> On Thu, 28 Jun 2007 20:27:22 +0200 (CEST) Geert Uytterhoeven <[EMAIL
> PROTECTED]> wrote:
> > > > endif
> > > >
> > > > obj-$(CONFIG_GENERIC_IOMAP) += iomap.o
> > > > -obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o
> > > > +obj-$(CONFIG_HAS_IOMEM)
On Thu, 28 Jun 2007 20:27:22 +0200 (CEST) Geert Uytterhoeven <[EMAIL
PROTECTED]> wrote:
> > > endif
> > >
> > > obj-$(CONFIG_GENERIC_IOMAP) += iomap.o
> > > -obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o
> > > +obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o check_signature.o
> > > obj-$
On Thu, 28 Jun 2007, Andrew Morton wrote:
> On Thu, 28 Jun 2007 15:37:15 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote:
>
> > From: Heiko Carstens <[EMAIL PROTECTED]>
> >
> > check_signature() uses readb() and therefore should only be build on
> > CONFIG_HAS_IOMEM.
> >
> > Otherwise breaks s390
On Thu, 28 Jun 2007 15:37:15 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote:
> From: Heiko Carstens <[EMAIL PROTECTED]>
>
> check_signature() uses readb() and therefore should only be build on
> CONFIG_HAS_IOMEM.
>
> Otherwise breaks s390:
> lib/check_signature.c: In function `check_signature':
From: Heiko Carstens <[EMAIL PROTECTED]>
check_signature() uses readb() and therefore should only be build on
CONFIG_HAS_IOMEM.
Otherwise breaks s390:
lib/check_signature.c: In function `check_signature':
lib/check_signature.c:19: error: implicit declaration of function `readb'
Cc: Martin Schwid
13 matches
Mail list logo
