Re: [patch]cleanup and error reporting for sound/core/init.c

2007-01-16 Thread Takashi Iwai
At Sat, 13 Jan 2007 07:37:59 +0100, Oliver Neukum wrote: > > Am Freitag, 12. Januar 2007 18:42 schrieb Takashi Iwai: > > At Fri, 12 Jan 2007 14:49:57 +0100, > > Oliver Neukum wrote: > > > > > > + } else { > > > + if (idx < snd_ecards_limit) { > > > + if (snd_cards_lock &

Re: [patch]cleanup and error reporting for sound/core/init.c

2007-01-12 Thread Oliver Neukum
Am Freitag, 12. Januar 2007 18:42 schrieb Takashi Iwai: > At Fri, 12 Jan 2007 14:49:57 +0100, > Oliver Neukum wrote: > > > > + } else { > > +if (idx < snd_ecards_limit) { > > + if (snd_cards_lock & (1 << idx)) > > + err = -EBUSY; /* inval

Re: [patch]cleanup and error reporting for sound/core/init.c

2007-01-12 Thread Takashi Iwai
At Fri, 12 Jan 2007 14:49:57 +0100, Oliver Neukum wrote: > > + } else { > + if (idx < snd_ecards_limit) { > + if (snd_cards_lock & (1 << idx)) > + err = -EBUSY; /* invalid */ > + } else if (idx < SNDRV_CARDS) > +

[patch]cleanup and error reporting for sound/core/init.c

2007-01-12 Thread Oliver Neukum
Hi, please accept this patch, which makes the control flow clear with indentation, adds some comments and improves error reporting. Regards Oliver Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> -- --- a/sound/core/init.c 2007-01-12 14:26:47.0 +0100 +++ b/sound/