Re: [patch] tty: amiserial.c: remove a double irq restore

2016-08-04 Thread Dan Carpenter
Oh... Wow. I'm really sorry about that. Thanks for catching the mistake. It should as well have been caught by static analysis but it wasn't. I will work on this so it doesn't happen again. And I will try to be more careful as well. regards, dan carpenter

[patch] tty: amiserial.c: remove a double irq restore

2016-08-03 Thread Dan Carpenter
We already called "local_irq_restore(flags);" so this isn't needed. Signed-off-by: Dan Carpenter diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c index 208f573..2f33cf1 100644 --- a/drivers/tty/amiserial.c +++ b/drivers/tty/amiserial.c @@ -880,7 +880,6 @@ static int rs_write(struct

Re: [patch] tty: amiserial.c: remove a double irq restore

2016-08-03 Thread Jiri Slaby
On 08/04/2016, 07:34 AM, Dan Carpenter wrote: > We already called "local_irq_restore(flags);" so this isn't needed. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c > index 208f573..2f33cf1 100644 > --- a/drivers/tty/amiserial.c > +++ b/drivers/