Re: [patch] sound/soc/codec : fix build failure in next-201303225

On Mon, Mar 25, 2013 at 08:34:27PM +0800, Xiong Zhou wrote: > On Mon, 25 Mar 2013, Mark Brown wrote: > > No, this isn't a good fix at all - we're moving the array to the header > > but still exporting it from this file which is not clever at all. The > > user should be conditional. > Yes, I agre

Re: [patch] sound/soc/codec : fix build failure in next-201303225

On Mon, 25 Mar 2013, Mark Brown wrote: > On Mon, Mar 25, 2013 at 07:59:43PM +0800, Xiong Zhou wrote: > > > -const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE] = { > > - "SYNCCLK rate", "8kHz", "16kHz", "ASYNCCLK rate", > > -}; > > +extern const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZ

[patch] sound/soc/codec : fix build failure in next-201303225

From: Xiong Zhou This patch fixes build failure of next-20130325 (and also next-20130322), about sound soc codec modules, based on previous implementation. Failing message: MODPOST 2490 modules ERROR: "arizona_rate_text" [sound/soc/codecs/snd-soc-wm-adsp.ko] undefined! ERROR: "arizona_ra

Re: [patch] sound/soc/codec : fix build failure in next-201303225

On Mon, Mar 25, 2013 at 07:59:43PM +0800, Xiong Zhou wrote: > -const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE] = { > - "SYNCCLK rate", "8kHz", "16kHz", "ASYNCCLK rate", > -}; > +extern const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE]; > EXPORT_SYMBOL_GPL(arizona_rate_text); No, th