Re: [patch] remove sys_set_zone_reclaim()

2005-08-02 Thread Ingo Molnar
* Martin Hicks <[EMAIL PROTECTED]> wrote: > On Mon, Aug 01, 2005 at 09:54:26PM +0200, Ingo Molnar wrote: > > > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > We could perhaps add a CAP_SYS_ADMIN-only sysctl for this hack, > > > > > > That would be more appropriate. > > > > > > (I'm

Re: [patch] remove sys_set_zone_reclaim()

2005-08-02 Thread Martin Hicks
On Mon, Aug 01, 2005 at 09:54:26PM +0200, Ingo Molnar wrote: > > * Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > We could perhaps add a CAP_SYS_ADMIN-only sysctl for this hack, > > > > That would be more appropriate. > > > > (I'm still not sure what happened to the idea of adding a call to

Re: [patch] remove sys_set_zone_reclaim()

2005-08-01 Thread Christoph Lameter
On Mon, 1 Aug 2005, Andrew Morton wrote: > (I'm still not sure what happened to the idea of adding a call to "clear > out this node+zone's pagecache now" rather than "set this noed+zone's > policy") Yes, We need the clear this zones page cache functionality. I am not sure what the Martin's recl

Re: [patch] remove sys_set_zone_reclaim()

2005-08-01 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > > We could perhaps add a CAP_SYS_ADMIN-only sysctl for this hack, > > That would be more appropriate. > > (I'm still not sure what happened to the idea of adding a call to > "clear out this node+zone's pagecache now" rather than "set this > noed+z

Re: [patch] remove sys_set_zone_reclaim()

2005-08-01 Thread Andrew Morton
Ingo Molnar <[EMAIL PROTECTED]> wrote: > > the patch below removes sys_set_zone_reclaim() for now. Probably the right thing to do. > ... > Firstly, the syscall lacks basic syscall design: e.g. it allows the > global setting of VM policy for unprivileged users. (!) Martin sent a patch to make

[patch] remove sys_set_zone_reclaim()

2005-08-01 Thread Ingo Molnar
the patch below removes sys_set_zone_reclaim() for now. While i'm sure Martin is trying to solve a real problem, we must not hard-code an incomplete and insufficient approach into a syscall, because syscalls are pretty much for eternity. I am quite strongly convinced that this syscall must not