Re: [patch] ns558 bug

2005-02-07 Thread Vojtech Pavlik
On Fri, Feb 04, 2005 at 09:00:54PM +0100, matthieu castet wrote: > Hi, > > this patch is based on http://bugzilla.kernel.org/show_bug.cgi?id=2962 > patch from adam belay. > > It solve a oops when pnp_register_driver(&ns558_pnp_driver) failed. > > Please apply this patch. Thanks; applied. --

Re: [patch] ns558 bug

2005-02-05 Thread matthieu castet
Hi, Andrew Morton wrote: [EMAIL PROTECTED] (Adam Belay) wrote: On Fri, Feb 04, 2005 at 09:00:54PM +0100, matthieu castet wrote: > Hi, > > this patch is based on http://bugzilla.kernel.org/show_bug.cgi?id=2962 > patch from adam belay. > > It solve a oops when pnp_register_driver(&ns558_pnp_driver

Re: [patch] ns558 bug

2005-02-04 Thread Andrew Morton
[EMAIL PROTECTED] (Adam Belay) wrote: > > As a more general solution for all drivers, I've been thinking about doing > something like this in the long term. > > int ret; > if (!(ret = register_driver(&ns558_driver))) > return ret; > add_driver_protocol(&ns558_driver, &ns558_pnp); > add

Re: [patch] ns558 bug

2005-02-04 Thread Adam Belay
On Fri, Feb 04, 2005 at 07:21:15PM -0800, Andrew Morton wrote: > [EMAIL PROTECTED] (Adam Belay) wrote: > > > > It looks ok. My only concern is what would happen if the isa probe > > succeded > > but the pnp_register_driver failed? "pnp_register_driver" return -ENODEV > > if > > "CONFIG_PNP"

Re: [patch] ns558 bug

2005-02-04 Thread Adam Belay
On Fri, Feb 04, 2005 at 07:06:14PM -0800, Andrew Morton wrote: It looks ok. My only concern is what would happen if the isa probe succeded but the pnp_register_driver failed? "pnp_register_driver" return -ENODEV if "CONFIG_PNP" isn't enabled. Do you think this would conflict with legacy probing

Re: [patch] ns558 bug

2005-02-04 Thread Andrew Morton
[EMAIL PROTECTED] (Adam Belay) wrote: > > It looks ok. My only concern is what would happen if the isa probe succeded > but the pnp_register_driver failed? "pnp_register_driver" return -ENODEV if > "CONFIG_PNP" isn't enabled. Do you think this would conflict with legacy > probing? Fair enou

Re: [patch] ns558 bug

2005-02-04 Thread Andrew Morton
[EMAIL PROTECTED] (Adam Belay) wrote: > > On Fri, Feb 04, 2005 at 09:00:54PM +0100, matthieu castet wrote: > > Hi, > > > > this patch is based on http://bugzilla.kernel.org/show_bug.cgi?id=2962 > > patch from adam belay. > > > > It solve a oops when pnp_register_driver(&ns558_pnp_driver) f

Re: [patch] ns558 bug

2005-02-04 Thread Adam Belay
On Fri, Feb 04, 2005 at 09:00:54PM +0100, matthieu castet wrote: > Hi, > > this patch is based on http://bugzilla.kernel.org/show_bug.cgi?id=2962 > patch from adam belay. > > It solve a oops when pnp_register_driver(&ns558_pnp_driver) failed. > > Please apply this patch. > > Matthieu I rememb

[patch] ns558 bug

2005-02-04 Thread matthieu castet
Hi, this patch is based on http://bugzilla.kernel.org/show_bug.cgi?id=2962 patch from adam belay. It solve a oops when pnp_register_driver(&ns558_pnp_driver) failed. Please apply this patch. Matthieu Index: drivers/input/gameport/ns558.c ===