Re: [patch] move wakeup code to .c

2008-02-19 Thread Rafael J. Wysocki
On Monday, 18 of February 2008, Rafael J. Wysocki wrote: > On Saturday, 16 of February 2008, Len Brown wrote: > > On Friday 15 February 2008 17:22, Rafael J. Wysocki wrote: > > > > > Ok, below is the version that survives checkpatch.pl, compiles on x86-32 > > > and has been successfully tested on

Re: [patch] move wakeup code to .c

2008-02-17 Thread Rafael J. Wysocki
On Saturday, 16 of February 2008, Len Brown wrote: > On Friday 15 February 2008 17:22, Rafael J. Wysocki wrote: > > > Ok, below is the version that survives checkpatch.pl, compiles on x86-32 > > and has been successfully tested on 32-bit and 64-bit systems. > > works on my t61 in 64-bit mode too.

Re: [patch] move wakeup code to .c

2008-02-15 Thread Len Brown
On Friday 15 February 2008 17:22, Rafael J. Wysocki wrote: > Ok, below is the version that survives checkpatch.pl, compiles on x86-32 > and has been successfully tested on 32-bit and 64-bit systems. works on my t61 in 64-bit mode too. applied to acpi-test. thanks, -Len -- To unsubscribe from th

Re: [patch] move wakeup code to .c

2008-02-15 Thread Len Brown
On Friday 15 February 2008 17:22, Rafael J. Wysocki wrote: > Ok, below is the version that survives checkpatch.pl, compiles on x86-32 > and has been successfully tested on 32-bit and 64-bit systems. works on my t61 in 64-bit mode too. applied to acpi-test. thanks, -Len -- To unsubscribe from th

Re: [patch] move wakeup code to .c

2008-02-15 Thread Rafael J. Wysocki
On Friday, 15 of February 2008, Len Brown wrote: > scripts/checkpatch.pl > ERROR: do not initialise externals to 0 or NULL > #113: FILE: arch/x86/boot/video-mode.c:29: > +int do_restore = 0;/* Screen contents changed during mode flip */ > > WARNING: Use of volatile is usually wrong: see > Doc

Re: [patch] move wakeup code to .c

2008-02-15 Thread Rafael J. Wysocki
On Friday, 15 of February 2008, Pavel Machek wrote: > Hi! > > > scripts/checkpatch.pl > > ERROR: do not initialise externals to 0 or NULL > > #113: FILE: arch/x86/boot/video-mode.c:29: > > +int do_restore = 0;/* Screen contents changed during mode flip */ > > We were doing file move with mini

Re: [patch] move wakeup code to .c

2008-02-15 Thread Pavel Machek
Hi! > scripts/checkpatch.pl > ERROR: do not initialise externals to 0 or NULL > #113: FILE: arch/x86/boot/video-mode.c:29: > +int do_restore = 0;/* Screen contents changed during mode flip */ We were doing file move with minimal changes. > ERROR: need a space before the open parenthesis '('

Re: [patch] move wakeup code to .c

2008-02-14 Thread Len Brown
scripts/checkpatch.pl ERROR: do not initialise externals to 0 or NULL #113: FILE: arch/x86/boot/video-mode.c:29: +int do_restore = 0;/* Screen contents changed during mode flip */ WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #644: FILE: arch/x86

[patch] move wakeup code to .c

2008-02-10 Thread Pavel Machek
I think .c wakeup code is ready for some more testing. HPA and Rafael did coding, so I added them as signed-off-by:. (Plus Rafael actually thinks its ready for -mm, I agree.) Pavel --- Move wakeup code to .c, so that video mode set