Re: [patch] mm: vmscan: invoke slab shrinkers from shrink_zone()

2015-04-24 Thread Vlastimil Babka
On 04/17/2015 07:06 AM, Joonsoo Kim wrote: On Thu, Apr 16, 2015 at 10:34:13AM -0400, Johannes Weiner wrote: Hi Joonsoo, On Thu, Apr 16, 2015 at 12:57:36PM +0900, Joonsoo Kim wrote: Hello, Johannes. Ccing Vlastimil, because this patch causes some regression on stress-highalloc test in mmtests

Re: [patch] mm: vmscan: invoke slab shrinkers from shrink_zone()

2015-04-16 Thread Joonsoo Kim
On Fri, Apr 17, 2015 at 09:17:53AM +1000, Dave Chinner wrote: > On Thu, Apr 16, 2015 at 10:34:13AM -0400, Johannes Weiner wrote: > > On Thu, Apr 16, 2015 at 12:57:36PM +0900, Joonsoo Kim wrote: > > > This causes following success rate regression of phase 1,2 on > > > stress-highalloc > > > benchma

Re: [patch] mm: vmscan: invoke slab shrinkers from shrink_zone()

2015-04-16 Thread Joonsoo Kim
On Thu, Apr 16, 2015 at 10:34:13AM -0400, Johannes Weiner wrote: > Hi Joonsoo, > > On Thu, Apr 16, 2015 at 12:57:36PM +0900, Joonsoo Kim wrote: > > Hello, Johannes. > > > > Ccing Vlastimil, because this patch causes some regression on > > stress-highalloc test in mmtests and he is a expert on com

Re: [patch] mm: vmscan: invoke slab shrinkers from shrink_zone()

2015-04-16 Thread Dave Chinner
On Thu, Apr 16, 2015 at 10:34:13AM -0400, Johannes Weiner wrote: > On Thu, Apr 16, 2015 at 12:57:36PM +0900, Joonsoo Kim wrote: > > This causes following success rate regression of phase 1,2 on > > stress-highalloc > > benchmark. The situation of phase 1,2 is that many high order allocations > >

Re: [patch] mm: vmscan: invoke slab shrinkers from shrink_zone()

2015-04-16 Thread Johannes Weiner
Hi Joonsoo, On Thu, Apr 16, 2015 at 12:57:36PM +0900, Joonsoo Kim wrote: > Hello, Johannes. > > Ccing Vlastimil, because this patch causes some regression on > stress-highalloc test in mmtests and he is a expert on compaction > and would have interest on it. :) > > On Fri, Nov 28, 2014 at 07:06:

Re: [patch] mm: vmscan: invoke slab shrinkers from shrink_zone()

2015-04-15 Thread Joonsoo Kim
Hello, Johannes. Ccing Vlastimil, because this patch causes some regression on stress-highalloc test in mmtests and he is a expert on compaction and would have interest on it. :) On Fri, Nov 28, 2014 at 07:06:37PM +0300, Vladimir Davydov wrote: > Hi Johannes, > > The patch generally looks good t

Re: [patch] mm: vmscan: invoke slab shrinkers from shrink_zone()

2014-11-28 Thread Vladimir Davydov
Hi Johannes, The patch generally looks good to me, because it simplifies the code flow significantly and makes it easier for me to introduce per memcg slab reclaim (thanks!). However, it has one serious flaw. Please see the comment inline. On Tue, Nov 25, 2014 at 01:23:50PM -0500, Johannes Weiner

Re: [patch] mm: vmscan: invoke slab shrinkers from shrink_zone()

2014-11-26 Thread Andrew Morton
On Tue, 25 Nov 2014 13:23:50 -0500 Johannes Weiner wrote: > The slab shrinkers are currently invoked from the zonelist walkers in > kswapd, direct reclaim, and zone reclaim, all of which roughly gauge > the eligible LRU pages and assemble a nodemask to pass to NUMA-aware > shrinkers, which then a

[patch] mm: vmscan: invoke slab shrinkers from shrink_zone()

2014-11-25 Thread Johannes Weiner
The slab shrinkers are currently invoked from the zonelist walkers in kswapd, direct reclaim, and zone reclaim, all of which roughly gauge the eligible LRU pages and assemble a nodemask to pass to NUMA-aware shrinkers, which then again have to walk over the nodemask. This is redundant code, extra