Re: [patch] mm, page_alloc: set num_movable in move_freepages()

2018-10-16 Thread Vlastimil Babka
On 10/5/18 11:21 PM, Andrew Morton wrote: > On Fri, 5 Oct 2018 13:56:39 -0700 (PDT) David Rientjes > wrote: > >> If move_freepages() returns 0 because zone_spans_pfn(), *num_movable can > > move_free_pages_block()? !zone_spans_pfn()? Also the subject would be more accurate if it

Re: [patch] mm, page_alloc: set num_movable in move_freepages()

2018-10-07 Thread David Rientjes
On Fri, 5 Oct 2018, Andrew Morton wrote: > On Fri, 5 Oct 2018 13:56:39 -0700 (PDT) David Rientjes > wrote: > > > If move_freepages() returns 0 because zone_spans_pfn(), *num_movable can > > move_free_pages_block()? !zone_spans_pfn()? > move_freepages_block() more accurately, y

Re: [patch] mm, page_alloc: set num_movable in move_freepages()

2018-10-05 Thread Andrew Morton
On Fri, 5 Oct 2018 13:56:39 -0700 (PDT) David Rientjes wrote: > If move_freepages() returns 0 because zone_spans_pfn(), *num_movable can move_free_pages_block()? !zone_spans_pfn()? > hold the value from the stack because it does not get initialized in > move_freepages(). > > Mo

[patch] mm, page_alloc: set num_movable in move_freepages()

2018-10-05 Thread David Rientjes
If move_freepages() returns 0 because zone_spans_pfn(), *num_movable can hold the value from the stack because it does not get initialized in move_freepages(). Move the initialization to move_freepages_block() to guarantee the value actually makes sense. This currently doesn't affect its only cal